lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Feb 2020 09:57:23 +0100 From: Cornelia Huck <cohuck@...hat.com> To: Gerd Hoffmann <kraxel@...hat.com> Cc: dri-devel@...ts.freedesktop.org, olvaffe@...il.com, smitterl@...hat.com, gurchetansingh@...omium.org, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, virtualization@...ts.linux-foundation.org (open list:VIRTIO GPU DRIVER), linux-kernel@...r.kernel.org (open list) Subject: Re: [PATCH] drm/virtio: fix error check On Fri, 14 Feb 2020 09:01:00 +0100 Gerd Hoffmann <kraxel@...hat.com> wrote: > The >= compare op must happen in cpu byte order, doing it in > little endian fails on big endian machines like s390. > > Reported-by: Sebastian Mitterle <smitterl@...hat.com> > Signed-off-by: Gerd Hoffmann <kraxel@...hat.com> > --- > drivers/gpu/drm/virtio/virtgpu_vq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c > index cfe9c54f87a3..67caecde623e 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_vq.c > +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c > @@ -222,7 +222,7 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *work) > trace_virtio_gpu_cmd_response(vgdev->ctrlq.vq, resp); > > if (resp->type != cpu_to_le32(VIRTIO_GPU_RESP_OK_NODATA)) { > - if (resp->type >= cpu_to_le32(VIRTIO_GPU_RESP_ERR_UNSPEC)) { > + if (le32_to_cpu(resp->type) >= VIRTIO_GPU_RESP_ERR_UNSPEC) { > struct virtio_gpu_ctrl_hdr *cmd; > cmd = virtio_gpu_vbuf_ctrl_hdr(entry); > DRM_ERROR_RATELIMITED("response 0x%x (command 0x%x)\n", Reviewed-by: Cornelia Huck <cohuck@...hat.com> Endianness continues to be fun.
Powered by blists - more mailing lists