linux-kernel - Re: [PATCH RESEND] KVM: X86: Grab KVM's srcu lock when accessing hv assist page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANRm+CwVyRgkG1MEHp25zNrqPoJoV72h7HUz_5n_5GWonj5mwQ@mail.gmail.com>
Date:   Fri, 14 Feb 2020 16:59:18 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, kvm <kvm@...r.kernel.org>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH RESEND] KVM: X86: Grab KVM's srcu lock when accessing hv
 assist page

On Fri, 14 Feb 2020 at 16:58, Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> On 14/02/20 09:51, Wanpeng Li wrote:
> > From: Wanpeng Li <wanpengli@...cent.com>
> >
> > Acquire kvm->srcu for the duration of mapping eVMCS to fix a bug where accessing
> > hv assist page derefences ->memslots without holding ->srcu or ->slots_lock.
>
> Perhaps nested_sync_vmcs12_to_shadow should be moved to
> prepare_guest_switch, where the SRCU is already taken.

Will do.

    Wanpeng