linux-kernel - Re: [patch V2 02/17] ARM: vdso: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60daf0c9-a765-514c-072c-9f7f9eec1e46@arm.com>
Date:   Fri, 14 Feb 2020 10:21:50 +0000
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, John Stultz <john.stultz@...aro.org>,
        Andy Lutomirski <luto@...nel.org>,
        Christophe Leroy <christophe.leroy@....fr>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Juergen Gross <jgross@...e.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        Sasha Levin <sashal@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        James Hogan <jhogan@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Marc Zyngier <maz@...nel.org>, Andrei Vagin <avagin@...il.com>
Subject: Re: [patch V2 02/17] ARM: vdso: Remove unused function

On 2/7/20 12:38 PM, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@...utronix.de>
> 
> The function is nowhere used. Aside of that this check should only cover
> the high resolution parts of the VDSO which require a VDSO capable
> clocksource and not the complete functionality as the name suggests. Will
> be replaced with something more useful.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>
Tested-by: Vincenzo Frascino <vincenzo.frascino@....com>

> ---
>  arch/arm/include/asm/vdso/vsyscall.h |    7 -------
>  1 file changed, 7 deletions(-)
> 
> --- a/arch/arm/include/asm/vdso/vsyscall.h
> +++ b/arch/arm/include/asm/vdso/vsyscall.h
> @@ -50,13 +50,6 @@ int __arm_get_clock_mode(struct timekeep
>  #define __arch_get_clock_mode __arm_get_clock_mode
>  
>  static __always_inline
> -int __arm_use_vsyscall(struct vdso_data *vdata)
> -{
> -	return vdata[CS_HRES_COARSE].clock_mode;
> -}
> -#define __arch_use_vsyscall __arm_use_vsyscall
> -
> -static __always_inline
>  void __arm_sync_vdso_data(struct vdso_data *vdata)
>  {
>  	flush_dcache_page(virt_to_page(vdata));
> 

-- 
Regards,
Vincenzo