linux-kernel - Re: [PATCH v5 2/5] iio: amplifiers: ad8366: Add write_raw_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Feb 2020 14:05:55 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Beniamin Bia <beniamin.bia@...log.com>
Cc:     <lars@...afoo.de>, <Michael.Hennerich@...log.com>,
        <pmeerw@...erw.net>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <biabeniamin@...look.com>,
        <knaack.h@....de>, <robh+dt@...nel.org>, <mark.rutland@....com>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 2/5] iio: amplifiers: ad8366: Add write_raw_get_fmt
 function

On Thu, 6 Feb 2020 17:11:46 +0200
Beniamin Bia <beniamin.bia@...log.com> wrote:

> This patch add write_raw_get_fmt function to specify conversion for
> hardware gain.
> 
> Signed-off-by: Beniamin Bia <beniamin.bia@...log.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
> Changes in v5:
> -nothing changed
> 
>  drivers/iio/amplifiers/ad8366.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
> index 0176d3d8cc9c..95972ab60f42 100644
> --- a/drivers/iio/amplifiers/ad8366.c
> +++ b/drivers/iio/amplifiers/ad8366.c
> @@ -180,9 +180,22 @@ static int ad8366_write_raw(struct iio_dev *indio_dev,
>  	return ret;
>  }
>  
> +static int ad8366_write_raw_get_fmt(struct iio_dev *indio_dev,
> +				    struct iio_chan_spec const *chan,
> +				    long mask)
> +{
> +	switch (mask) {
> +	case IIO_CHAN_INFO_HARDWAREGAIN:
> +		return IIO_VAL_INT_PLUS_MICRO_DB;
> +	default:
> +		return -EINVAL;
> +	}
> +}
> +
>  static const struct iio_info ad8366_info = {
>  	.read_raw = &ad8366_read_raw,
>  	.write_raw = &ad8366_write_raw,
> +	.write_raw_get_fmt = &ad8366_write_raw_get_fmt,
>  };
>  
>  #define AD8366_CHAN(_channel) {				\