linux-kernel - Re: [PATCH v9 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200214140844.GL4827@sirena.org.uk>
Date:   Fri, 14 Feb 2020 14:08:44 +0000
From:   Mark Brown <broonie@...nel.org>
To:     "Ramuthevar,Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        vigneshr@...com, mark.rutland@....com, robh+dt@...nel.org,
        devicetree@...r.kernel.org, dan.carpenter@...cle.com,
        cheol.yong.kim@...el.com, qi-ming.wu@...el.com
Subject: Re: [PATCH v9 1/2] dt-bindings: spi: Add schema for Cadence QSPI
 Controller driver

On Fri, Feb 14, 2020 at 07:46:17PM +0800, Ramuthevar,Vadivel MuruganX wrote:

> +  - compatible : should be one of the following:
> +        Generic default - "cdns,qspi-nor".
> +        For TI 66AK2G SoC - "ti,k2g-qspi", "cdns,qspi-nor".
> +        For TI AM654 SoC  - "ti,am654-ospi", "cdns,qspi-nor".
> +        For Intel LGM SoC - "intel,lgm-qspi", "cdns,qspi-nor".

There are already existing bindings for several of these compatibles,
we should not be adding a second binding for something which already has
a binding but rather continuing to use the same binding.  This is the
whole point of documenting a binding that's separate to the implementation.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)