linux-kernel - Re: [PATCH] ARM: dts: ls1021a: Restore MDIO compatible to gianfar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Feb 2020 10:34:46 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     devicetree@...r.kernel.org, leoyang.li@....com,
        claudiu.manoil@....com, robh+dt@...nel.org, pavel@...x.de,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: ls1021a: Restore MDIO compatible to gianfar

On Sun, Jan 26, 2020 at 09:49:50PM +0200, Vladimir Oltean wrote:
> The difference between "fsl,etsec2-mdio" and "gianfar" has to do with
> the .get_tbipa function, which calculates the address of the TBIPA
> register automatically, if not explicitly specified. [ see
> drivers/net/ethernet/freescale/fsl_pq_mdio.c ]. On LS1021A, the TBIPA
> register is at offset 0x30 within the port register block, which is what
> the "gianfar" method of calculating addresses actually does.
> 
> Luckily, the bad "compatible" is inconsequential for ls1021a.dtsi,
> because the TBIPA register is explicitly specified via the second "reg"
> (<0x0 0x2d10030 0x0 0x4>), so the "get_tbipa" function is dead code.
> Nonetheless it's good to restore it to its correct value.
> 
> Background discussion:
> https://www.spinics.net/lists/stable/msg361156.html
> 
> Fixes: c7861adbe37f ("ARM: dts: ls1021: Fix SGMII PCS link remaining down after PHY disconnect")
> Reported-by: Pavel Machek <pavel@...x.de>
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Applied, thanks.