linux-kernel - Re: [PATCH 1/3] i2c: convert SMBus alert setup function to return an ERRPTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Feb 2020 07:20:20 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     <linux-i2c@...r.kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Phil Reid <preid@...ctromag.com.au>,
        Wolfram Sang <wsa@...-dreams.de>,
        Robert Richter <rrichter@...vell.com>,
        George Cherian <gcherian@...vell.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] i2c: convert SMBus alert setup function to return
 an ERRPTR

Hi Wolfram,

On Mon, 10 Feb 2020 18:29:25 +0100, Wolfram Sang wrote:
> Only few drivers use this call, so drivers and I2C core are converted at
> once with this patch. By simply using i2c_new_client_device() instead of
> i2c_new_device(), we easily can return an ERRPTR for this function as
> well. To make out of tree users aware that something changed, the
> function is renamed to i2c_install_smbus_alert().

I wouldn't bother renaming the function. Chances that there actually
are out-of-tree users of this function are pretty small, and if that is
the case, they can adjust their code easily in a way that is still
compatible with old kernels.

-- 
Jean Delvare
SUSE L3 Support