linux-kernel - Re: Re: [PATCH v4 10/11] mm/damon: Add kunit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200215065251.13754-1-sj38.park@gmail.com>
Date:   Sat, 15 Feb 2020 07:52:51 +0100
From:   SeongJae Park <sj38.park@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     sjpark@...zon.com, akpm@...ux-foundation.org,
        SeongJae Park <sjpark@...zon.de>, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, amit@...nel.org,
        brendan.d.gregg@...il.com, brendanhiggins@...gle.com, cai@....pw,
        colin.king@...onical.com, corbet@....net, dwmw@...zon.com,
        jolsa@...hat.com, kirill@...temov.name, mark.rutland@....com,
        mgorman@...e.de, minchan@...nel.org, mingo@...hat.com,
        namhyung@...nel.org, peterz@...radead.org, rostedt@...dmis.org,
        sj38.park@...il.com, vdavydov.dev@...il.com, linux-mm@...ck.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH v4 10/11] mm/damon: Add kunit tests

On Fri, 14 Feb 2020 20:07:47 -0800 Randy Dunlap <rdunlap@...radead.org> wrote:

> On 2/10/20 6:53 AM, sjpark@...zon.com wrote:
> > diff --git a/mm/Kconfig b/mm/Kconfig
> > index 387d469f40ec..b279ab9c78d0 100644
> > --- a/mm/Kconfig
> > +++ b/mm/Kconfig
> > @@ -751,4 +751,15 @@ config DAMON
> >  	  be 1) accurate enough to be useful for performance-centric domains,
> >  	  and 2) sufficiently light-weight so that it can be applied online.
> >  
> > +config DAMON_KUNIT_TEST
> > +	bool "Test for damon"
> 
> s/bool/tristate/ ?

Thank you for this comment!

It seems Kunit does not support module build, as its core functions are not
exported to modules.  That said, as this might be confusing and even could
cause a build failure with some configuration combinations[1], I will change
this dependency to `DAMON=y && KUNIT` in next spin.

[1] https://lore.kernel.org/linux-mm/20200214111907.7017-1-sjpark@amazon.com/

Thanks,
SeongJae Park

> 
> > +	depends on DAMON && KUNIT
> > +	help
> > +	  This builds the DAMON Kunit test suite.
> > +
> > +	  For more information on KUnit and unit tests in general, please refer
> > +	  to the KUnit documentation.
> > +
> > +	  If unsure, say N.
> > +
> >  endmenu
> 
> 
> -- 
> ~Randy
>