lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 16 Feb 2020 08:03:32 +1100 From: Finn Thain <fthain@...egraphics.com.au> To: "David S. Miller" <davem@...emloft.net> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Chris Zankel <chris@...kel.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH net-next 4/7] net/sonic: Remove redundant netif_start_queue() call The transmit queue must be running already otherwise sonic_send_packet() would not have been called. If the queue was stopped by the interrupt handler, the interrupt handler will restart it again. Tested-by: Stan Johnson <userm57@...oo.com> Signed-off-by: Finn Thain <fthain@...egraphics.com.au> --- drivers/net/ethernet/natsemi/sonic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c index 9ecdd67e1410..1d6de6706875 100644 --- a/drivers/net/ethernet/natsemi/sonic.c +++ b/drivers/net/ethernet/natsemi/sonic.c @@ -327,7 +327,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev) netif_dbg(lp, tx_queued, dev, "%s: stopping queue\n", __func__); netif_stop_queue(dev); /* after this packet, wait for ISR to free up some TDAs */ - } else netif_start_queue(dev); + } netif_dbg(lp, tx_queued, dev, "%s: issuing Tx command\n", __func__); -- 2.24.1
Powered by blists - more mailing lists