linux-kernel - Re: [PATCH] MIPS: VPE: Fix a double free and a memory leak in 'release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e487701.1c69fb81.107e8.b7f9@mx.google.com>
Date:   Sat, 15 Feb 2020 14:56:00 -0800
From:   Paul Burton <paulburton@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC:     linux-mips@...r.kernel.org
Subject: Re: [PATCH] MIPS: VPE: Fix a double free and a memory leak in  'release_vpe()'

Hello,

Christophe JAILLET wrote:
> Pointer on the memory allocated by 'alloc_progmem()' is stored in
> 'v->load_addr'. So this is this memory that should be freed by
> 'release_progmem()'.
> 
> 'release_progmem()' is only a call to 'kfree()'.
> 
> With the current code, there is both a double free and a memory leak.
> Fix it by passing the correct pointer to 'release_progmem()'.

Applied to mips-fixes.

> commit bef8e2dfceed
> https://git.kernel.org/mips/c/bef8e2dfceed
> 
> Fixes: e01402b115ccc ("More AP / SP bits for the 34K, the Malta bits and things. Still wants")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Signed-off-by: Paul Burton <paulburton@...nel.org>

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paulburton@...nel.org to report it. ]