[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200215011552.GE7778@bombadil.infradead.org>
Date: Fri, 14 Feb 2020 17:15:52 -0800
From: Matthew Wilcox <willy@...radead.org>
To: John Hubbard <jhubbard@...dia.com>
Cc: linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org,
linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org,
linux-f2fs-devel@...ts.sourceforge.net, cluster-devel@...hat.com,
ocfs2-devel@....oracle.com, linux-xfs@...r.kernel.org
Subject: Re: [PATCH v5 03/13] mm: Put readahead pages in cache earlier
On Thu, Feb 13, 2020 at 07:36:38PM -0800, John Hubbard wrote:
> I see two distinct things happening in this patch, and I think they want to each be
> in their own patch:
>
> 1) A significant refactoring of the page loop, and
>
> 2) Changing the place where the page is added to the page cache. (Only this one is
> mentioned in the commit description.)
>
> We'll be more likely to spot any errors if these are teased apart.
Thanks. I ended up splitting this patch into three, each hopefully
easier to understand.
Powered by blists - more mailing lists