linux-kernel - Re: [PATCH] init/main.c: mark boot_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 16 Feb 2020 21:03:33 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Qiujun Huang <hqjagain@...il.com>
Cc:     akpm@...ux-foundation.org, mhiramat@...nel.org,
        rostedt@...dmis.org, keescook@...omium.org, rppt@...ux.ibm.com,
        linux@...inikbrodowski.net, nivedita@...m.mit.edu,
        nadav.amit@...il.com, glider@...gle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init/main.c: mark boot_config_checksum static

On Sun, 16 Feb 2020 19:28:31 +0800
Qiujun Huang <hqjagain@...il.com> wrote:

> In fact, this function is only used in this file, so mark it with 'static'.

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!

> 
> Signed-off-by: Qiujun Huang <hqjagain@...il.com>
> ---
>  init/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/main.c b/init/main.c
> index f95b014..534589f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -335,7 +335,7 @@ static char * __init xbc_make_cmdline(const char *key)
>  	return new_cmdline;
>  }
>  
> -u32 boot_config_checksum(unsigned char *p, u32 size)
> +static u32 boot_config_checksum(unsigned char *p, u32 size)
>  {
>  	u32 ret = 0;
>  
> -- 
> 1.8.3.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>