linux-kernel - Re: [PATCH v4 1/2] dt-bindings: Documentation for qcom,eud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f19fe93-3af2-1050-4d80-ed568865d825@codeaurora.org>
Date:   Sun, 16 Feb 2020 18:41:30 +0530
From:   "Dwivedi, Avaneesh Kumar (avani)" <akdwived@...eaurora.org>
To:     Bryan O'Donoghue <pure.logic@...us-software.ie>,
        linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, ckadabi@...eaurora.org,
        tsoni@...eaurora.org, bryanh@...eaurora.org,
        psodagud@...eaurora.org, rnayak@...eaurora.org,
        satyap@...eaurora.org, pheragu@...eaurora.org
Subject: Re: [PATCH v4 1/2] dt-bindings: Documentation for qcom,eud

Thank you very much Bryan for your review comments, will be working on 
your and other maintainers comment on this patchset and will be posting 
new patchset soon.

On 2/4/2020 8:21 AM, Bryan O'Donoghue wrote:
> On 31/01/2020 04:43, Avaneesh Kumar Dwivedi wrote:
>> Documentation for Embedded USB Debugger (EUD) device tree bindings.
>>
>> Signed-off-by: Satya Durga Srinivasu Prabhala <satyap@...eaurora.org>
>> Signed-off-by: Prakruthi Deepak Heragu <pheragu@...eaurora.org>
>> Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@...eaurora.org>
>> ---
>>   .../devicetree/bindings/soc/qcom/qcom,msm-eud.txt  | 43 
>> ++++++++++++++++++++++
>>   1 file changed, 43 insertions(+)
>>   create mode 100644 
>> Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt 
>> b/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
>> new file mode 100644
>> index 0000000..57476ce
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
>> @@ -0,0 +1,43 @@
>> +* Qualcomm Technologies Inc Embedded USB Debugger (EUD)
>> +
>> +The EUD (Embedded USB Debugger) is a mini-USB hub implemented
>> +on chip to support the USB-based debug and trace capabilities.
>
> on chip to support USB-based debug and trace capabilities.
OK
>
>> +
>> +Required properties:
>> +
>> + - compatible:  Should be "qcom,msm-eud"
>> + - interrupts:  Interrupt number
>> + - reg: Should be address and size of EUD register space
>> +
>> +EUD notifies clients for VBUS attach/detach and charger enable/disable
>> +events. The link between event consumer(i.e.USB controller for vbus
> missing space
> consumer (i.e.
Ok
>
>> +attach/detach event) and EUD is established via a directed graph. EUD
>> +act 
> The EUD acts
OK
>
>> as an output link and clients of EUD as input link of this directed
>> +graph. Events flows through the directed graph only during debug mode.
>
> Probably this is a very obvious question but, you mean debug and trace 
> events or do you mean VBUS/charger events?
Directed graph is to show VBUS and charger events flow.
>
>> +
>> +An example for EUD device node:
>> +
>> +    eud: qcom,msm-eud@...0000 {
>> +        compatible = "qcom,msm-eud";
>> +        interrupts = <GIC_SPI 492 IRQ_TYPE_LEVEL_HIGH>;
>> +        reg = <0x88e0000 0x4000>;
>> +        usb_con: connector {
>> +            compatible = "usb-c-connector";
>> +            label = "USB-C";
>> +            port {
>> +                eud_usb_output: endpoint {
>> +                    remote-endpoint = <&eud_usb3_input>;
>> +                };
>> +            };
>> +        };
>> +    };
>> +
>> +An example for EUD client:
>> +
>> +    usb3 {
>> +        port {
>> +            eud_usb3_input: endpoint {
>> +                remote-endpoint = <&eud_usb_output>;
>> +            };
>> +        };
>> +    };
>>
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.