linux-kernel - Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200217190745.GA147152@lenoch>
Date:   Mon, 17 Feb 2020 20:07:45 +0100
From:   Ladislav Michl <ladis@...ux-mips.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com, linux-omap@...r.kernel.org
Subject: Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns
 -EPROBE_DEFER

On Mon, Feb 17, 2020 at 07:38:16PM +0100, H. Nikolaus Schaller wrote:
> Hi,
> 
> > Am 17.02.2020 um 19:29 schrieb Ladislav Michl <ladis@...ux-mips.org>:
> > 
> > On Mon, Feb 17, 2020 at 02:58:14PM +0100, H. Nikolaus Schaller wrote:
> >> 
> >>> Am 17.02.2020 um 14:38 schrieb H. Nikolaus Schaller <hns@...delico.com>:
> >>> 
> >>> If the gpios are probed after this driver (e.g. if they
> >>> come from an i2c expander) there is no need to print an
> >>> error message.
> >>> 
> >>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> >>> ---
> >>> drivers/extcon/extcon-palmas.c | 8 ++++++--
> >>> 1 file changed, 6 insertions(+), 2 deletions(-)
> >>> 
> >>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> >>> index edc5016f46f1..cea58d0cb457 100644
> >>> --- a/drivers/extcon/extcon-palmas.c
> >>> +++ b/drivers/extcon/extcon-palmas.c
> >>> @@ -205,14 +205,18 @@ static int palmas_usb_probe(struct platform_device *pdev)
> >>> 
> >>> 	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> >>> 							GPIOD_IN);
> >>> -	if (IS_ERR(palmas_usb->id_gpiod)) {
> >>> +	if (PTR_ERR(palmas_usb->id_gpiod) == -EPROBE_DEFER) {
> >>> +		return -EPROBE_DEFER;
> >>> +	} else if (IS_ERR(palmas_usb->id_gpiod)) {
> >> 
> >> Hm.
> >> 
> >> While looking again at that: why do we need the "{" and "} else "?
> >> 
> >> It should be sufficient to have
> >> 
> >>> 	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> >>> 							GPIOD_IN);
> >>> +	if (PTR_ERR(palmas_usb->id_gpiod) == -EPROBE_DEFER)
> >>> +		return -EPROBE_DEFER;
> >>> 	if (IS_ERR(palmas_usb->id_gpiod)) {
> >> 
> >> What do you think is better coding style here?
> > 
> > How about something like this? (just an idea with some work left for you ;-))
> > 
> > --- a/drivers/extcon/extcon-palmas.c
> > +++ b/drivers/extcon/extcon-palmas.c
> > @@ -206,8 +206,10 @@ static int palmas_usb_probe(struct platform_device *pdev)
> > 	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> > 							GPIOD_IN);
> > 	if (IS_ERR(palmas_usb->id_gpiod)) {
> > -		dev_err(&pdev->dev, "failed to get id gpio\n");
> > -		return PTR_ERR(palmas_usb->id_gpiod);
> > +		status = PTR_ERR(palmas_usb->id_gpiod);
> > +		if (status != -EPROBE_DEFER)
> > +			dev_err(&pdev->dev, "failed to get id gpio: %d\n", status);
> > +		return status;
> > 	}
> 
> Well, what would be the improvement?

Linux kernel prints so many lines on bootup and only few of them are
valuable. Lets improve it by printing error value to give a clue
why it failed.

> It needs an additional variable and makes the change more complex.

That additional variable is already there...

> The main suggestion by Chanwoo Choi was to move the check for EPROBE_DEFER
> outside of the IS_ERR() because checking this first and then for EPROBE_DEFER
> is not necessary.

True, but there are two checks either way and this is slow path.

> If acceptable I'd prefer my last proposal. It just adds 2 LOC before
> and without touching the existing if (IS_ERR(...)).

I have no strong opinion. I was just waiting for project to compile
so, consider my reply as product of boredom :)
(However, I do not like "let's touch only minimal number of lines"
argument. End result should still matter more)

> If the compiler is clever it can cache palmas_usb->id_gpiod in a register
> which serves the same purpose as the status variable.

I'm not trying to outsmart compiler, but note status variable is needed
three times.

> > 
> > 	palmas_usb->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus",
> 
> BR and thanks,
> Nikolaus