lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Feb 2020 11:51:42 +0800 From: Ran Bi <ran.bi@...iatek.com> To: Yingjoe Chen <yingjoe.chen@...iatek.com> CC: Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>, Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Matthias Brugger <matthias.bgg@...il.com>, Mark Rutland <mark.rutland@....com>, Alessandro Zummo <a.zummo@...ertech.it>, Josef Friedl <josef.friedl@...ed.at>, <srv_heupstream@...iatek.com>, Frank Wunderlich <frank-w@...lic-files.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Sean Wang <sean.wang@...iatek.com>, <linux-kernel@...r.kernel.org>, Richard Fontana <rfontana@...hat.com>, <devicetree@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>, Thomas Gleixner <tglx@...utronix.de>, Eddie Huang <eddie.huang@...iatek.com>, <linux-rtc@...r.kernel.org>, Sean Wang <sean.wang@...iatek.com>, Josef Friedl <josef.friedl@...ed.at>, "Frank Wunderlich" <frank-w@...lic-files.de> Subject: Re: [PATCH v8 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC On Tue, 2020-02-04 at 00:50 +0800, Yingjoe Chen wrote: > > diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h > > index f84b916..fffe34a 100644 > > --- a/include/linux/mfd/mt6397/rtc.h > > +++ b/include/linux/mfd/mt6397/rtc.h > > @@ -18,7 +18,8 @@ > > #define RTC_BBPU_CBUSY BIT(6) > > #define RTC_BBPU_KEY (0x43 << 8) > > > > -#define RTC_WRTGR 0x003c > > +#define RTC_WRTGR_MT6358 0x3a > > +#define RTC_WRTGR_MT6397 0x3c > > > > #define RTC_IRQ_STA 0x0002 > > #define RTC_IRQ_STA_AL BIT(0) > > @@ -57,6 +58,10 @@ > > #define MTK_RTC_POLL_DELAY_US 10 > > #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ)) > > > > +struct mtk_rtc_data { > > + u32 wrtgr; > > +}; > > + > > struct mt6397_rtc { > > struct device *dev; > > struct rtc_device *rtc_dev; > > @@ -66,6 +71,15 @@ struct mt6397_rtc { > > struct regmap *regmap; > > int irq; > > u32 addr_base; > > + const struct mtk_rtc_data *data; > > +}; > > + > > +static const struct mtk_rtc_data mt6358_rtc_data = { > > + .wrtgr = RTC_WRTGR_MT6358, > > +}; > > + > > +static const struct mtk_rtc_data mt6397_rtc_data = { > > + .wrtgr = RTC_WRTGR_MT6397, > > }; > > Hi, > > Putting these in header file doesn't looks right to me. > Who need this? can you move them back to rtc-mt6397.c? > > Joe.C > This could also effect kernel/drivers/power/reset/mt6323-poweroff.c which using same region of RTC registers. There are 2 ways of modification: 1. kernel/drivers/rtc/rtc-mt6397.c implement do_pwroff function and export to mt6323-poweroff.c 2. Just modify mt6323-poweroff.c file to compatible this patch. I mean using RTC_WRTGR_MT6397 to replace RTC_WRTGR. Or modify mt6323-poweroff.c like rtc-mt6397.c
Powered by blists - more mailing lists