linux-kernel - Re: [PATCH v8 20/22] clk: tegra: Remove tegra_pmc_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200217095550.GD1345979@ulmo>
Date:   Mon, 17 Feb 2020 10:55:50 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Sowjanya Komatineni <skomatineni@...dia.com>
Cc:     jonathanh@...dia.com, broonie@...nel.org, lgirdwood@...il.com,
        perex@...ex.cz, tiwai@...e.com, digetx@...il.com,
        mperttunen@...dia.com, gregkh@...uxfoundation.org,
        sboyd@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        pdeschrijver@...dia.com, pgaikwad@...dia.com, spujar@...dia.com,
        josephl@...dia.com, daniel.lezcano@...aro.org,
        mmaddireddy@...dia.com, markz@...dia.com,
        devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 20/22] clk: tegra: Remove tegra_pmc_clk_init along
 with clk ids

On Mon, Jan 13, 2020 at 11:24:25PM -0800, Sowjanya Komatineni wrote:
> Current Tegra clock driver registers PMC clocks clk_out_1, clk_out_2,
> clk_out_3 and 32KHz blink output in tegra_pmc_init() which does direct
> PMC register access during clk_ops and these PMC register read and write
> access will not happen when PMC is in secure mode.
> 
> Any direct PMC register access from non-secure world will not go
> through.
> 
> All the PMC clocks are moved to Tegra PMC driver with PMC as a clock
> provider.
> 
> This patch removes tegra_pmc_clk_init along with corresponding clk ids
> from Tegra clock driver.
> 
> Tested-by: Dmitry Osipenko <digetx@...il.com>
> Reviewed-by: Dmitry Osipenko <digetx@...il.com>
> Signed-off-by: Sowjanya Komatineni <skomatineni@...dia.com>
> ---
>  drivers/clk/tegra/Makefile        |   1 -
>  drivers/clk/tegra/clk-id.h        |   7 ---
>  drivers/clk/tegra/clk-tegra-pmc.c | 122 --------------------------------------
>  drivers/clk/tegra/clk-tegra114.c  |  17 +-----
>  drivers/clk/tegra/clk-tegra124.c  |  33 ++++-------
>  drivers/clk/tegra/clk-tegra20.c   |   4 --
>  drivers/clk/tegra/clk-tegra210.c  |  17 +-----
>  drivers/clk/tegra/clk-tegra30.c   |  18 +-----
>  drivers/clk/tegra/clk.h           |   1 -
>  9 files changed, 19 insertions(+), 201 deletions(-)
>  delete mode 100644 drivers/clk/tegra/clk-tegra-pmc.c

I think it's best to defer this patch (along with 21 and 22) until all
the others have been merged to make sure we don't regress. Other than
that it should be fine to apply the others in any order, right? Well,
maybe not any order, but at least the ASoC patches should be able to
go through the ASoC tree without impacting functionality, right?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)