linux-kernel - Re: [PATCH] extcon: palmas: hide error messages if gpio returns -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Feb 2020 19:15:42 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     "H. Nikolaus Schaller" <hns@...delico.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com, linux-omap@...r.kernel.org
Subject: Re: [PATCH] extcon: palmas: hide error messages if gpio returns
 -EPROBE_DEFER

Hi,

On 2/17/20 5:55 PM, H. Nikolaus Schaller wrote:
> If the gpios are probed after this driver (e.g. if they
> come from an i2c expander) there is no need to print an
> error message.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>  drivers/extcon/extcon-palmas.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index edc5016f46f1..9c6254c0531c 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -206,14 +206,16 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
>  							GPIOD_IN);
>  	if (IS_ERR(palmas_usb->id_gpiod)) {
> -		dev_err(&pdev->dev, "failed to get id gpio\n");
> +		if (PTR_ERR(palmas_usb->id_gpiod) != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "failed to get id gpio\n");
>  		return PTR_ERR(palmas_usb->id_gpiod);
>  	}
>  
>  	palmas_usb->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus",
>  							GPIOD_IN);
>  	if (IS_ERR(palmas_usb->vbus_gpiod)) {
> -		dev_err(&pdev->dev, "failed to get vbus gpio\n");
> +		if (PTR_ERR(palmas_usb->vbus_gpiod) != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "failed to get vbus gpio\n");
>  		return PTR_ERR(palmas_usb->vbus_gpiod);
>  	}
>  
> 

Usually, gpio driver like pinctrl is very early probed
because almost device drivers should use gpio.
So, I have not any experience about this situation.
Do you meet this situation on any h/w board?

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics