linux-kernel - Re: [PATCH 1/1] net/rds: Track user mapped pages through special API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200216.183731.2157450869886971370.davem@davemloft.net>
Date:   Sun, 16 Feb 2020 18:37:31 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jhubbard@...dia.com
Cc:     akpm@...ux-foundation.org, santosh.shilimkar@...cle.com,
        hans.westgaard.ry@...cle.com, leonro@...lanox.com, kuba@...nel.org,
        netdev@...r.kernel.org, rds-devel@....oracle.com,
        linux-rdma@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] net/rds: Track user mapped pages through special
 API

From: John Hubbard <jhubbard@...dia.com>
Date: Tue, 11 Feb 2020 19:03:55 -0800

> From: Leon Romanovsky <leonro@...lanox.com>
> 
> Convert net/rds to use the newly introduces pin_user_pages() API,
> which properly sets FOLL_PIN. Setting FOLL_PIN is now required for
> code that requires tracking of pinned pages.
> 
> Note that this effectively changes the code's behavior: it now
> ultimately calls set_page_dirty_lock(), instead of set_page_dirty().
> This is probably more accurate.
> 
> As Christoph Hellwig put it, "set_page_dirty() is only safe if we are
> dealing with a file backed page where we have reference on the inode it
> hangs off." [1]
> 
> [1] https://lore.kernel.org/r/20190723153640.GB720@lst.de
> 
> Cc: Hans Westgaard Ry <hans.westgaard.ry@...cle.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@...cle.com>
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>

Applied, thank you.