linux-kernel - Re: [PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200217104516.GA94720@kroah.com>
Date:   Mon, 17 Feb 2020 11:45:16 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chanwoo Choi <cw00.choi@...sung.com>
Cc:     chanwoo@...nel.org, myungjoo.ham@...sung.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: Remove unneeded extern keyword from
 extcon-provider.h

On Mon, Feb 17, 2020 at 07:47:28PM +0900, Chanwoo Choi wrote:
> The commit tb7365587f513 ("extcon: Remove unneeded extern keyword
> from extcon.h") removes the unneeded extern keyword from extcon header
> file. But, The commit tb7365587f513 has missed that deletes 'extern'
> keyword from extcon-provider.h. So that it deletes extern keyword
> from extcon-provider.h.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
> Dear Greg,
> 
> When I removed the unneeded extern keyword from extcon hearder file for
> v5.6-rc1, although I should remove 'extern' keyword on both extcon.h
> and extcon-provider.h, I only removed them from extcon.h. It was my mistake.
> 
> So that I send this patch for v5.6-rc3 release.
> Could you review and apply it to char-misc git repository directly?

Sure, but it's not really a bugfix, I'll queue it up for 5.7-rc1, ok?

thanks,

greg k-h