linux-kernel - Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200216.185600.43507558643527863.davem@davemloft.net>
Date:   Sun, 16 Feb 2020 18:56:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     manivannan.sadhasivam@...aro.org
Cc:     kuba@...nel.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from
 userspace

From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Date: Thu, 13 Feb 2020 14:44:26 +0530

> +static int service_announce_new(struct sockaddr_qrtr *dest,
> +				struct qrtr_server *srv)
> +{
> +	struct qrtr_ctrl_pkt pkt;
> +	struct msghdr msg = { };
> +	struct kvec iv = { &pkt, sizeof(pkt) };

Please use reverse christmas tree ordering for local variables.

Please fix this for your entire submission.