linux-kernel - Re: [PATCH 1/2] usb: audio-v2: Add uac2_effect_unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hd0adguv9.wl-tiwai@suse.de>
Date:   Mon, 17 Feb 2020 15:18:34 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     alsa-devel@...a-project.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb: audio-v2: Add uac2_effect_unit_descriptor definition

On Thu, 13 Feb 2020 12:20:58 +0100,
Takashi Iwai wrote:
> 
> The UAC2 Effect Unit Descriptor has a slightly different definition
> from other similar ones like Processing Unit or Extension Unit.
> Define it here so that it can be used in USB-audio driver in a later
> patch.
> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> ---
>  include/linux/usb/audio-v2.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/usb/audio-v2.h b/include/linux/usb/audio-v2.h
> index ba4b3e3327ff..cb9900b34b67 100644
> --- a/include/linux/usb/audio-v2.h
> +++ b/include/linux/usb/audio-v2.h
> @@ -156,6 +156,18 @@ struct uac2_feature_unit_descriptor {
>  	__u8 bmaControls[0]; /* variable length */
>  } __attribute__((packed));
>  
> +/* 4.7.2.10 Effect Unit Descriptor */
> +
> +struct uac2_effect_unit_descriptor {
> +	__u8 bLength;
> +	__u8 bDescriptorType;
> +	__u8 bDescriptorSubtype;
> +	__u8 bUnitID;
> +	__le16 wEffectType;
> +	__u8 bSourceID;
> +	__u8 bmaControls[]; /* variable length */
> +} __attribute__((packed));
> +
>  /* 4.9.2 Class-Specific AS Interface Descriptor */
>  
>  struct uac2_as_header_descriptor {

Greg, I suppose you are OK with this addition?


thanks,

Takashi