lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Feb 2020 11:28:11 +0800 From: Chen-Yu Tsai <wens@...e.org> To: Samuel Holland <samuel@...lland.org> Cc: Mark Brown <broonie@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Maxime Ripard <mripard@...nel.org>, Vasily Khoruzhick <anarsoul@...il.com>, Luca Weiss <luca@...tu.xyz>, Linux-ALSA <alsa-devel@...a-project.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org>, Ondrej Jirman <megous@...ous.com> Subject: Re: [PATCH 1/8] ASoC: sun50i-codec-analog: Fix duplicate use of ADC enable bits On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland <samuel@...lland.org> wrote: > > The same enable bits are currently used for both the "Left/Right ADC" > and the "Left/Right ADC Mixer" widgets. This happens to work in practice > because the widgets are always enabled/disabled at the same time, but > each register bit should only be associated with a single widget. > > To keep symmetry with the DAC widgets, keep the bits on the ADC widgets, > and remove them from the ADC Mixer widgets. > > Fixes: 42371f327df0 ("ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls") > Reported-by: Ondrej Jirman <megous@...ous.com> > Signed-off-by: Samuel Holland <samuel@...lland.org> Acked-by: Chen-Yu Tsai <wens@...e.org>
Powered by blists - more mailing lists