lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Feb 2020 18:13:38 +0100 From: Paolo Bonzini <pbonzini@...hat.com> To: Vitaly Kuznetsov <vkuznets@...hat.com>, Krish Sadhukhan <krish.sadhukhan@...cle.com>, linmiaohe <linmiaohe@...wei.com> Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org, rkrcmar@...hat.com, sean.j.christopherson@...el.com, wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com Subject: Re: [PATCH] KVM: apic: remove unused function apic_lvt_vector() On 17/02/20 18:02, Vitaly Kuznetsov wrote: > > Also, apic_lvt_enabled() is only used once with APIC_LVTT as the second > argument so I'd suggest we also do: > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > index afcd30d44cbb..d85463ff4a6f 100644 > --- a/arch/x86/kvm/lapic.c > +++ b/arch/x86/kvm/lapic.c > @@ -289,14 +289,14 @@ static inline void kvm_apic_set_x2apic_id(struct kvm_lapic *apic, u32 id) > recalculate_apic_map(apic->vcpu->kvm); > } > > -static inline int apic_lvt_enabled(struct kvm_lapic *apic, int lvt_type) > +static inline int apic_lvtt_enabled(struct kvm_lapic *apic) > { > - return !(kvm_lapic_get_reg(apic, lvt_type) & APIC_LVT_MASKED); > + return !(kvm_lapic_get_reg(apic, APIC_LVTT) & APIC_LVT_MASKED); > } > > -static inline int apic_lvt_vector(struct kvm_lapic *apic, int lvt_type) > +static inline int apic_lvtt_vector(struct kvm_lapic *apic) > { > - return kvm_lapic_get_reg(apic, lvt_type) & APIC_VECTOR_MASK; > + return kvm_lapic_get_reg(apic, APIC_LVTT) & APIC_VECTOR_MASK; > } > > in addition to the above. > > -- Vitaly Sounds good. Paolo
Powered by blists - more mailing lists