linux-kernel - Re: Applied "ASoC: core: ensure component names are unique" to the asoc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Feb 2020 18:23:21 +0100
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
        linux-kernel@...r.kernel.org,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Subject: Re: Applied "ASoC: core: ensure component names are unique" to the
 asoc tree

Am 17.02.20 um 15:36 schrieb Marek Szyprowski:
> Hi Jerome,
>
> On 17.02.2020 14:18, Jerome Brunet wrote:
>> On Mon 17 Feb 2020 at 13:13, Marek Szyprowski <m.szyprowski@...sung.com> wrote:
>>> On 14.02.2020 21:56, Mark Brown wrote:
>>>> Thanks,
>>>> Mark
>>>>
>>>>   From b2354e4009a773c00054b964d937e1b81cb92078 Mon Sep 17 00:00:00 2001
>>>> From: Jerome Brunet <jbrunet@...libre.com>
>>>> Date: Fri, 14 Feb 2020 14:47:04 +0100
>>>> Subject: [PATCH] ASoC: core: ensure component names are unique
>>>>
>>>> Make sure each ASoC component is registered with a unique name.
>>>> The component is derived from the device name. If a device registers more
>>>> than one component, the component names will be the same.
>>>>
>>>> This usually brings up a warning about the debugfs directory creation of
>>>> the component since directory already exists.
>>>>
>>>> In such case, start numbering the component of the device so the names
>>>> don't collide anymore.
>>>>
>>>> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
>>>> Link: https://lore.kernel.org/r/20200214134704.342501-1-jbrunet@baylibre.com
>>>> Signed-off-by: Mark Brown <broonie@...nel.org>
>>> This patch landed in today's linux-next and I've noticed that it breaks
>>> registration of VC4 DRM driver on Raspberry Pi3 boards (I've compiled
>>> kernel from bcm2835_defconfig):
>> I think I have an idea about what is going on. (good catch in the defer BTW)
>>
>> 1) Funny to see that the vc4-hdmi already registers several (3) ASoC
>> components. It must have had warning about the debugfs entry before this patch.
> Okay, right, before this patch there is a warning from debugfs I've 
> missed (debugfs was not enabled in bcm2835_defconfig):

This is unintended. I've seen patches which restored DEBUG_FS support
because of this commit:

0e4a459f56c32d tracing: Remove unnecessary DEBUG_FS dependency

Best regards
Stefan