lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Feb 2020 18:24:38 +0100 From: Boris Brezillon <boris.brezillon@...labora.com> To: Schrempf Frieder <frieder.schrempf@...tron.de> Cc: Boris Brezillon <bbrezillon@...nel.org>, Jeff Kletsky <git-commits@...ycomm.com>, liaoweixiong <liaoweixiong@...winnertech.com>, Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "stable@...r.kernel.org" <stable@...r.kernel.org> Subject: Re: [PATCH v2 3/3] mtd: spinand: Don not erase the block before writing a bad block marker In the subject: s/Don not/Do not/ On Mon, 17 Feb 2020 15:54:12 +0000 Schrempf Frieder <frieder.schrempf@...tron.de> wrote: > From: Frieder Schrempf <frieder.schrempf@...tron.de> > > Currently when marking a block, we use spinand_erase_op() to erase > the block before writing the marker to the OOB area. Doing so without > waiting for the operation to finish can lead to the marking failing > silently and no bad block marker being written to the flash. > > In fact we don't need to do an erase at all before writing the BBM. > The ECC is disabled for the raw access to the OOB data and we don't s/the raw access/raw accesses/ > need to work around any issues with chips reporting ECC errors as it > is known to be the case for raw NAND. > > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") > Cc: stable@...r.kernel.org > Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de> Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com> > --- > Changes in v2: > * Instead of waiting for the erase operation to finish, just don't > do an erase at all, as it is not needed. > * Update the commit message > --- > drivers/mtd/nand/spi/core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index a94287884453..8dda51bbdd11 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -613,7 +613,6 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) > }; > int ret; > > - /* Erase block before marking it bad. */ > ret = spinand_select_target(spinand, pos->target); > if (ret) > return ret; > @@ -622,8 +621,6 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) > if (ret) > return ret; > > - spinand_erase_op(spinand, pos); > - > return spinand_write_page(spinand, &req); > } >
Powered by blists - more mailing lists