linux-kernel - Re: [PATCH v2 4.14] padata: Remove broken queue flushing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Feb 2020 05:48:00 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Daniel Jordan <daniel.m.jordan@...cle.com>
Cc:     Sasha Levin <sashal@...nel.org>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        linux-kernel@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        stable@...r.kernel.org
Subject: Re: [PATCH v2 4.14] padata: Remove broken queue flushing

On Fri, Feb 14, 2020 at 02:46:51PM -0500, Daniel Jordan wrote:
> From: Herbert Xu <herbert@...dor.apana.org.au>
> 
> [ Upstream commit 07928d9bfc81640bab36f5190e8725894d93b659 ]
> 
> The function padata_flush_queues is fundamentally broken because
> it cannot force padata users to complete the request that is
> underway.  IOW padata has to passively wait for the completion
> of any outstanding work.
> 
> As it stands flushing is used in two places.  Its use in padata_stop
> is simply unnecessary because nothing depends on the queues to
> be flushed afterwards.
> 
> The other use in padata_replace is more substantial as we depend
> on it to free the old pd structure.  This patch instead uses the
> pd->refcnt to dynamically free the pd structure once all requests
> are complete.
> 
> Fixes: 2b73b07ab8a4 ("padata: Flush the padata queues actively")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> Reviewed-by: Daniel Jordan <daniel.m.jordan@...cle.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> [dj: leave "pd->pinst = pinst" assignment in padata_alloc_pd()]
> Signed-off-by: Daniel Jordan <daniel.m.jordan@...cle.com>

Thanks, all 3 backports now queued up.

greg k-h