linux-kernel - Re: [PATCH v5 1/3] dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for Qualcomm DWC3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200218210258.GA29667@bogus>
Date:   Tue, 18 Feb 2020 15:02:58 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sandeep Maheswaram <sanm@...eaurora.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Felipe Balbi <balbi@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Manu Gautam <mgautam@...eaurora.org>,
        Chandana Kishori Chiluveru <cchiluve@...eaurora.org>
Subject: Re: [PATCH v5 1/3] dt-bindings: usb: qcom,dwc3: Introduce
 interconnect properties for Qualcomm DWC3 driver

On Fri, Feb 14, 2020 at 01:54:42PM +0530, Sandeep Maheswaram wrote:
> Add documentation for the interconnects and interconnect-names
> properties for USB.
> 
> Signed-off-by: Sandeep Maheswaram <sanm@...eaurora.org>
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index 4a36ab5..236877e 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -68,6 +68,22 @@ properties:
>    resets:
>      maxItems: 1
>  
> +  interconnects:
> +    description:
> +      Pairs of phandles and interconnect provider specifiers
> +      to denote the edge source and destination ports of
> +      the interconnect path. Please refer to
> +      Documentation/devicetree/bindings/interconnect/
> +      for more details.

No need to redefine a common property, but you do need to define how 
many entries (maxItems).

> +
> +  interconnect-names:
> +    description:
> +      List of interconnect path name strings sorted in the same
> +      order as the interconnects property. Consumer drivers will use
> +      interconnect-names to match interconnect paths with interconnect
> +      specifiers. Please refer to Documentation/devicetree/bindings/
> +      interconnect/ for more details.

Need to define what the names are.

Rob