linux-kernel - Re: [PATCH v4] perf stat: Show percore counts in per CPU output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200218061422.GA384398@krava>
Date:   Tue, 18 Feb 2020 07:14:22 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     "Jin, Yao" <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v4] perf stat: Show percore counts in per CPU output

On Tue, Feb 18, 2020 at 09:02:52AM +0800, Jin, Yao wrote:

SNIP

> > > > 
> > > > thanks,
> > > > jirka
> > > > 
> > > 
> > > I have a simple fix for this misalignment issue.
> > > 
> > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> > > index bc31fccc0057..95b29c9cba36 100644
> > > --- a/tools/perf/util/stat-display.c
> > > +++ b/tools/perf/util/stat-display.c
> > > @@ -114,11 +114,11 @@ static void aggr_printout(struct perf_stat_config
> > > *config,
> > >                          fprintf(config->output, "S%d-D%d-C%*d%s",
> > >                                  cpu_map__id_to_socket(id),
> > >                                  cpu_map__id_to_die(id),
> > > -                               config->csv_output ? 0 : -5,
> > > +                               config->csv_output ? 0 : -3,
> > >                                  cpu_map__id_to_cpu(id), config->csv_sep);
> > >                  } else {
> > > -                       fprintf(config->output, "CPU%*d%s ",
> > > -                               config->csv_output ? 0 : -5,
> > > +                       fprintf(config->output, "CPU%*d%s",
> > > +                               config->csv_output ? 0 : -7,
> > >                                  evsel__cpus(evsel)->map[id],
> > >                                  config->csv_sep);
> > 
> > I guess that's ok, will that work with higher (3 digit) cpu numbers?
> > 
> > jirka
> > 
> 
> Yes, it works with hundreds of CPU. I have tested with that case.
> 
> BTW, do you need me to post a separate patch or you will add this fix in
> your patch series?

please send separate patch

thanks,
jirka