linux-kernel - Re: [PATCH v4] Bluetooth: hci_qca: Bug fixes while collecting controller memory dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D1EF879E-B55C-4904-A0E7-0065B999B6D4@holtmann.org>
Date:   Tue, 18 Feb 2020 09:30:40 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Balakrishna Godavarthi <bgodavar@...eaurora.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Bluez mailing list <linux-bluetooth@...r.kernel.org>,
        Hemantg <hemantg@...eaurora.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        Rocky Liao <rjliao@...eaurora.org>,
        Yoni Shavit <yshavit@...gle.com>, abhishekpandit@...omium.org,
        Venkata Lakshmi Narayana Gubba <gubbaven@...eaurora.org>
Subject: Re: [PATCH v4] Bluetooth: hci_qca: Bug fixes while collecting
 controller memory dump

Hi Balakrishna,

> This patch will fix the below issues
> 1. Discarding memory dump events if memdump state is moved to
>    MEMDUMP_TIMEOUT.
> 2. Fixed race conditions between qca_hw_error() and qca_controller_memdump
>    while free memory dump buffers using mutex lock
> 3. Moved timeout timer to delayed work queue
> 4. Injecting HW error event in a case when dumps failed to receive and HW
>    error event is not yet received.
> 5. Clearing hw error and command timeout function callbacks before
>    sending pre shutdown command.
> 
> Collecting memory dump will follow any of the below sequence.
> 
> Sequence 1:
>   Receiving Memory dump events from the controller
>   Received entire dump in stipulated time
>   Received HW error event from the controller
>   Controller Reset from HOST
> 
> Sequence 2:
>   Receiving Memory dump events from the controller
>   Failed to Receive entire dump in stipulated time
>   A Timeout schedules and if no HW error event received a fake HW
>     error event will be injected.
>   Controller Reset from HOST.
> 
> Sequence 3:
>   Received HW error event
>   HOST trigger SSR by sending crash packet to controller.
>   Received entire dump in stipulated time
>   Controller Reset from HOST
> 
> Fixes: d841502c79e3 ("Bluetooth: hci_qca: Collect controller memory dump during SSR")
> Reported-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@...eaurora.org>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> ---
> drivers/bluetooth/hci_qca.c | 101 ++++++++++++++++++++++++------------
> 1 file changed, 67 insertions(+), 34 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel