linux-kernel - Re:Re: [PATCH] powerpc/sysdev: fix compile errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 18 Feb 2020 18:25:11 +0800 (GMT+08:00)
From:   王文虎 <wenhu.wang@...o.com>
To:     Christophe Leroy <christophe.leroy@....fr>
Cc:     Andrew Donnellan <ajd@...ux.ibm.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Richard Fontana <rfontana@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, wangwenhu <wenhu.pku@...il.com>,
        Paul Mackerras <paulus@...ba.org>, trivial@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        linuxppc-dev@...ts.ozlabs.org, lonehugo@...mail.com
Subject: Re:Re: [PATCH] powerpc/sysdev: fix compile errors


From: Christophe Leroy <christophe.leroy@....fr>
 Date: 2020-01-21 16:37:07
To:"王文虎" <wenhu.wang@...o.com>,Andrew Donnellan <ajd@...ux.ibm.com>
 cc: Kate Stewart <kstewart@...uxfoundation.org>,Richard Fontana <rfontana@...hat.com>,Greg Kroah-Hartman <gregkh@...uxfoundation.org>,linux-kernel@...r.kernel.org,wangwenhu <wenhu.pku@...il.com>,Paul Mackerras <paulus@...ba.org>,trivial@...nel.org,Thomas Gleixner <tglx@...utronix.de>,linuxppc-dev@...ts.ozlabs.org,lonehugo@...mail.com
Subject: Re: [PATCH] powerpc/sysdev: fix compile errors>
>
>Le 21/01/2020 à 07:59, 王文虎 a écrit :
>> 发件人：Andrew Donnellan <ajd@...ux.ibm.com>
>> 发送日期：2020-01-21 14:13:07
>> 收件人：wangwenhu <wenhu.pku@...il.com>,Benjamin Herrenschmidt <benh@...nel.crashing.org>,Paul Mackerras <paulus@...ba.org>,Michael Ellerman <mpe@...erman.id.au>,Kate Stewart <kstewart@...uxfoundation.org>,Greg Kroah-Hartman <gregkh@...uxfoundation.org>,Richard Fontana <rfontana@...hat.com>,Thomas Gleixner <tglx@...utronix.de>,linuxppc-dev@...ts.ozlabs.org,linux-kernel@...r.kernel.org
>> 抄送人：trivial@...nel.org,lonehugo@...mail.com,wenhu.wang@...o.com
>> 主题：Re: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote:
>>>> From: wangwenhu <wenhu.wang@...o.com>
>>>>
>>>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
>>>> fix the implicit declaration compile errors when building Cache-Sram.
>>>>
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
>>>>     cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>>>                             ^~~~~~~~~~~~~~~~
>>>>                             bitmap_complement
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>>>     cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>>>                           ^
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
>>>>     iounmap(cache_sram->base_virt);
>>>>     ^~~~~~~
>>>>     roundup
>>>> cc1: all warnings being treated as errors
>>>>
>>>> Signed-off-by: wangwenhu <wenhu.wang@...o.com>
>>>
>>> How long has this code been broken for?
>> 
>> It's been broken almost 15 months since the commit below:
>> "commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1
>> Author: Christophe Leroy <christophe.leroy@....fr>
>> Date:   Tue Oct 9 13:51:41 2018 +0000
>> 
>>      powerpc: don't use ioremap_prot() nor __ioremap() unless really needed."
>> 
>> And we are working on it now for further development.
>
>That's pretty surprising. That commit didn't change the iounmap(). It 
>only replaced ioremap_prot() by ioremap_coherent(). Both are defined in io.h
>
>Christophe
>

The compile error exists since the uploading of the driver
Details below:
1. "ioremap_flags" defined in "asm/io.h" was used primarily(Wed Oct 13 17:30:56 2010):
(6db92cc9d07d: powerpc/85xx: add cache-sram support);
2. "ioremap_prot" was used to replace "ioremap_flags"
(40f1ce7fb7e8: powerpc: Remove ioremap_flags);
3. "ioremap_coherent" was used to replace "ioremap_prot":
(aa91796ec463: powerpc: don't use ioremap_prot() nor __ioremap() unless really needed.)

So I will do the re-patch with a "Fixed" tag and "<linux/io.h>" include modification.
Which commit should be referenced to append to "Fixed" tag? (No.1 or No.3 ?)

Wenhu

>> 
>>>
>>>> ---
>>>>    arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>>> index f6c665dac725..29b6868eff7d 100644
>>>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>>> @@ -17,6 +17,7 @@
>>>>    #include <linux/of_platform.h>
>>>>    #include <asm/pgtable.h>
>>>>    #include <asm/fsl_85xx_cache_sram.h>
>>>> +#include <asm/io.h>
>>>>
>>>>    #include "fsl_85xx_cache_ctlr.h"
>>>>
>>>
>>> -- 
>>> Andrew Donnellan              OzLabs, ADL Canberra
>>> ajd@...ux.ibm.com             IBM Australia Limited
>>>
>> 
>> Wenhu
>>