linux-kernel - Re: linux-next: Tree for Feb 18 (sound/soc/codecs/wm5110.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200218113116.GA4232@sirena.org.uk>
Date:   Tue, 18 Feb 2020 11:31:16 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        moderated for non-subscribers <alsa-devel@...a-project.org>,
        patches@...nsource.cirrus.com, geert@...ux-m68k.org
Subject: Re: linux-next: Tree for Feb 18 (sound/soc/codecs/wm5110.c)

On Tue, Feb 18, 2020 at 10:09:59AM +0000, Charles Keepax wrote:

> 1) We could update the machine drivers to do an imply as well,
> like the changes to SND_SOC_ALL_CODECS. I think this will
> generally work but doesn't really feel right as you can end up with
> the machine driver built without the CODEC.

Yes, that's not helpful.

> 2) We could update the machine drivers to a depends on and make
> the CODEC symbols manually selectable. I guess this also has the
> advantages that it would be necessary for the simple card stuff
> that seems to be everyones first choice for machine drivers these
> days.

That's not good, it means people have to know exactly what CODECs and
DAIs are on their board to even see the config option.

> Mark do you have any strong feelings on this I am leaning towards
> 2?

Why not just continue adding the relevant dependencies to the machine
drivers like we've always done?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)