linux-kernel - Re: [PATCH] phy: core: Fix phy_get() to not return error on link creation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9051ea53-29d4-bd7a-675b-9c534794b7af@st.com>
Date:   Tue, 18 Feb 2020 13:44:52 +0100
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Kishon Vijay Abraham I <kishon@...com>
CC:     <linux-kernel@...r.kernel.org>, youling257 <youling257@...il.com>
Subject: Re: [PATCH] phy: core: Fix phy_get() to not return error on link
 creation failure

Hi Kishon

On 2/18/20 1:14 PM, Kishon Vijay Abraham I wrote:
> commit 987351e1ea77 ("phy: core: Add consumer device link support")
> added device link support between PHY consumer and PHY provider.
> However certain peripherals (DWC3 ULPI) have cyclic dependency
> between the PHY provider and PHY consumer causing the device link
> creation to fail.
> 
> Instead of erroring out on failure to create device link, only add a
> debug print to indicate device link creation failed to get USB
> working again in multiple platforms.
> 
> Fixes: 987351e1ea77 ("phy: core: Add consumer device link support")
> Cc: Alexandre Torgue <alexandre.torgue@...com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---

I was close to send it also :). Thanks for it.

Reviewed-by: Alexandre TORGUE <alexandre.torgue@...com>

Thanks
Alex

>   drivers/phy/phy-core.c | 18 ++++++------------
>   1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index cd5a6c95dbdc..a27b8d578d7f 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -688,11 +688,9 @@ struct phy *phy_get(struct device *dev, const char *string)
>   	get_device(&phy->dev);
>   
>   	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
> -	if (!link) {
> -		dev_err(dev, "failed to create device link to %s\n",
> +	if (!link)
> +		dev_dbg(dev, "failed to create device link to %s\n",
>   			dev_name(phy->dev.parent));
> -		return ERR_PTR(-EINVAL);
> -	}
>   
>   	return phy;
>   }
> @@ -803,11 +801,9 @@ struct phy *devm_of_phy_get(struct device *dev, struct device_node *np,
>   	}
>   
>   	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
> -	if (!link) {
> -		dev_err(dev, "failed to create device link to %s\n",
> +	if (!link)
> +		dev_dbg(dev, "failed to create device link to %s\n",
>   			dev_name(phy->dev.parent));
> -		return ERR_PTR(-EINVAL);
> -	}
>   
>   	return phy;
>   }
> @@ -852,11 +848,9 @@ struct phy *devm_of_phy_get_by_index(struct device *dev, struct device_node *np,
>   	devres_add(dev, ptr);
>   
>   	link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
> -	if (!link) {
> -		dev_err(dev, "failed to create device link to %s\n",
> +	if (!link)
> +		dev_dbg(dev, "failed to create device link to %s\n",
>   			dev_name(phy->dev.parent));
> -		return ERR_PTR(-EINVAL);
> -	}
>   
>   	return phy;
>   }
>