linux-kernel - Re: [PATCH v3 00/12] Enable per-file/directory DAX operations V3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49zhdgasal.fsf@segfault.boston.devel.redhat.com>
Date:   Tue, 18 Feb 2020 09:22:58 -0500
From:   Jeff Moyer <jmoyer@...hat.com>
To:     Ira Weiny <ira.weiny@...el.com>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Dave Chinner <david@...morbit.com>,
        Christoph Hellwig <hch@....de>,
        "Theodore Y. Ts'o" <tytso@....edu>, Jan Kara <jack@...e.cz>,
        linux-ext4 <linux-ext4@...r.kernel.org>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v3 00/12] Enable per-file/directory DAX operations V3

Ira Weiny <ira.weiny@...el.com> writes:

> Yep...  and a long weekend if you are in the US...  I ran the test with V4 and
> got the panic below.
>
> Is this similar to what you see?  If so I'll work on it in V4.  FWIW with '-o

Yes, precisely.

> dax' specified I don't see how fsstress is causing an issue with my patch set.
> Does fsstress attempt to change dax states?  I don't see that in the test but
> I'm not real familiar with generic/013 and fsstress.

Not that I'm aware of, no.

> If my disassembly of read_pages is correct it looks like readpage is null which
> makes sense because all files should be IS_DAX() == true due to the mount option...
>
> But tracing code indicates that the patch:
>
> 	fs: remove unneeded IS_DAX() check
>
> ... may be the culprit and the following fix may work...
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 3a7863ba51b9..7eaf74a2a39b 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2257,7 +2257,7 @@ generic_file_read_iter(struct kiocb *iocb, struct iov_iter *iter)
>         if (!count)
>                 goto out; /* skip atime */
>  
> -       if (iocb->ki_flags & IOCB_DIRECT) {
> +       if (iocb->ki_flags & IOCB_DIRECT || IS_DAX(inode)) {
>                 struct file *file = iocb->ki_filp;
>                 struct address_space *mapping = file->f_mapping;
>                 struct inode *inode = mapping->host;

Well, you'll have to up-level the inode variable instantiation,
obviously.  That solves this particular issue.  The next traceback
you'll hit is in the writeback path:

[  116.044545] ------------[ cut here ]------------
[  116.049163] WARNING: CPU: 48 PID: 4469 at fs/dax.c:862 dax_writeback_mapping_range+0x397/0x530
...
[  116.134509] CPU: 48 PID: 4469 Comm: fsstress Not tainted 5.6.0-rc1+ #43
[  116.141121] Hardware name: Intel Corporation S2600WFD/S2600WFD, BIOS SE5C620.86B.0D.01.0395.022720191340 02/27/2019
[  116.151549] RIP: 0010:dax_writeback_mapping_range+0x397/0x530
[  116.157294] Code: ff ff 31 db 48 8b 7c 24 28 c6 07 00 0f 1f 40 00 fb 48 8b 7c 24 10 e8 98 fc 29 00 0f 1f 44 00 00 e9 f1 fc ff ff 4c 8b 64 24 08 <0f> 0b be fb ff ff ff 4c 89 e7 e8 fa 87 ed ff f0 41 80 8c 24 80 00
[  116.176036] RSP: 0018:ffffb9b162fa7c18 EFLAGS: 00010046
[  116.181261] RAX: 0000000000000000 RBX: 00000000000001ac RCX: 0000000000000020
[  116.188387] RDX: 0000000000000000 RSI: 00000000000001ac RDI: ffffb9b162fa7c40
[  116.195519] RBP: 0000000000000020 R08: ffff9a73dc24d6b0 R09: 0000000000000020
[  116.202648] R10: 0000000000000000 R11: 0000000000000238 R12: ffff9a73d92c66b8
[  116.209774] R13: ffffe4a09f0cb200 R14: 0000000000000000 R15: ffffe4a09f0cb200
[  116.216907] FS:  00007f2dbcd22b80(0000) GS:ffff9a7420c00000(0000) knlGS:0000000000000000
[  116.224992] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  116.230735] CR2: 00007fa21808b648 CR3: 000000179e0a2003 CR4: 00000000007606e0
[  116.237860] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  116.244990] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[  116.252115] PKRU: 55555554
[  116.254827] Call Trace:
[  116.257286]  do_writepages+0x41/0xd0
[  116.260862]  __filemap_fdatawrite_range+0xcb/0x100
[  116.265653]  filemap_write_and_wait_range+0x38/0x90
[  116.270579]  xfs_setattr_size+0x2c2/0x3e0 [xfs]
[  116.275126]  xfs_file_fallocate+0x239/0x440 [xfs]
[  116.279831]  ? selinux_file_permission+0x108/0x140
[  116.284622]  vfs_fallocate+0x14d/0x2f0
[  116.288374]  ksys_fallocate+0x3c/0x80
[  116.292039]  __x64_sys_fallocate+0x1a/0x20
[  116.296139]  do_syscall_64+0x55/0x1d0
[  116.299806]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[  116.304856] RIP: 0033:0x7f2dbc21983b
[  116.308435] Code: ff ff eb ba 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 8d 05 25 0e 2d 00 49 89 ca 8b 00 85 c0 75 14 b8 1d 01 00 00 0f 05 <48> 3d 00 f0 ff ff 77 5d c3 0f 1f 40 00 41 55 49 89 cd 41 54 49 89

That's here:

        /*
         * A page got tagged dirty in DAX mapping? Something is seriously
         * wrong.
         */
        if (WARN_ON(!xa_is_value(entry)))
                return -EIO;

Cheers,
Jeff