linux-kernel - Re: [PATCH -next] pinctrl: mediatek: remove set but not used variable 'e'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87f87073-6f0c-0b54-2f77-eaab1147eb28@gmail.com>
Date:   Tue, 18 Feb 2020 17:27:57 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>, sean.wang@...nel.org,
        linus.walleij@...aro.org, light.hsieh@...iatek.com
Cc:     linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...td.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] pinctrl: mediatek: remove set but not used variable
 'e'



On 18/02/2020 03:36, YueHaibing wrote:
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: In function mtk_hw_pin_field_lookup:
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:70:39: warning:
>  variable e set but not used [-Wunused-but-set-variable]
> 
> Since commit 3de7deefce69 ("pinctrl: mediatek: Check gpio pin
> number and use binary search in mtk_hw_pin_field_lookup()"),
> it is not used any more, so remove it, also remove redundant
> assignment to variable c, it will be assigned a new value later
> before used.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 1da9425..d3169a8 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -67,7 +67,7 @@ static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw,
>  				   const struct mtk_pin_desc *desc,
>  				   int field, struct mtk_pin_field *pfd)
>  {
> -	const struct mtk_pin_field_calc *c, *e;
> +	const struct mtk_pin_field_calc *c;
>  	const struct mtk_pin_reg_calc *rc;
>  	int start = 0, end, check;
>  	bool found = false;
> @@ -82,8 +82,6 @@ static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw,
>  	}
>  
>  	end = rc->nranges - 1;
> -	c = rc->range;
> -	e = c + rc->nranges;
>  
>  	while (start <= end) {
>  		check = (start + end) >> 1;
>