[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d606aeb2-5327-ff13-0043-e70ef37522f5@gmail.com>
Date: Tue, 18 Feb 2020 17:47:25 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: Macpaul Lin <macpaul.lin@...iatek.com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
mtk01761 <wendell.lin@...iatek.com>,
Fabien Parent <fparent@...libre.com>,
Weiyi Lu <weiyi.lu@...iatek.com>,
Mars Cheng <mars.cheng@...iatek.com>,
Sean Wang <Sean.Wang@...iatek.com>,
Owen Chen <owen.chen@...iatek.com>,
Chunfeng Yun <chunfeng.yun@...iatek.com>,
Evan Green <evgreen@...omium.org>,
Yong Wu <yong.wu@...iatek.com>, Joerg Roedel <jroedel@...e.de>,
Shawn Guo <shawnguo@...nel.org>,
Marc Zyngier <marc.zyngier@....com>,
Ryder Lee <Ryder.Lee@...iatek.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-clk@...r.kernel.org
Cc: Mediatek WSD Upstream <wsd_upstream@...iatek.com>,
CC Hwang <cc.hwang@...iatek.com>,
Loda Chou <loda.chou@...iatek.com>
Subject: Re: [PATCH v7 1/7] dt-bindings: clock: mediatek: document clk
bindings for Mediatek MT6765 SoC
On 07/02/2020 10:20, Macpaul Lin wrote:
> From: Mars Cheng <mars.cheng@...iatek.com>
>
> This patch adds the binding documentation for apmixedsys, audsys, camsys,
> imgsys, infracfg, mipi0a, topckgen, vcodecsys
>
> Signed-off-by: Mars Cheng <mars.cheng@...iatek.com>
> Signed-off-by: Owen Chen <owen.chen@...iatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> ---
> .../arm/mediatek/mediatek,apmixedsys.txt | 1 +
> .../bindings/arm/mediatek/mediatek,audsys.txt | 1 +
> .../bindings/arm/mediatek/mediatek,camsys.txt | 1 +
> .../bindings/arm/mediatek/mediatek,imgsys.txt | 1 +
> .../arm/mediatek/mediatek,infracfg.txt | 1 +
> .../bindings/arm/mediatek/mediatek,mipi0a.txt | 28 +++++++++++++++++++
> .../bindings/arm/mediatek/mediatek,mmsys.txt | 1 +
> .../arm/mediatek/mediatek,pericfg.txt | 1 +
> .../arm/mediatek/mediatek,topckgen.txt | 1 +
> .../arm/mediatek/mediatek,vcodecsys.txt | 27 ++++++++++++++++++
I think it's OK to put all the bindings, that only add one compatible in onw
patch. But I think mipi0a and vcodesys should each go into a separate patch, as
we will need a Ack by Rob for that.
Regards,
Matthias
> 10 files changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mipi0a.txt
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,vcodecsys.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
> index ff000ccade78..bd7a0fa5801b 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,apmixedsys.txt
> @@ -8,6 +8,7 @@ Required Properties:
> - compatible: Should be one of:
> - "mediatek,mt2701-apmixedsys"
> - "mediatek,mt2712-apmixedsys", "syscon"
> + - "mediatek,mt6765-apmixedsys", "syscon"
> - "mediatek,mt6779-apmixedsys", "syscon"
> - "mediatek,mt6797-apmixedsys"
> - "mediatek,mt7622-apmixedsys"
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt
> index e4ca7b703123..38309db115f5 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.txt
> @@ -7,6 +7,7 @@ Required Properties:
>
> - compatible: Should be one of:
> - "mediatek,mt2701-audsys", "syscon"
> + - "mediatek,mt6765-audsys", "syscon"
> - "mediatek,mt6779-audio", "syscon"
> - "mediatek,mt7622-audsys", "syscon"
> - "mediatek,mt7623-audsys", "mediatek,mt2701-audsys", "syscon"
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,camsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,camsys.txt
> index 1f4aaa15a37e..a0ce82085ad0 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,camsys.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,camsys.txt
> @@ -6,6 +6,7 @@ The MediaTek camsys controller provides various clocks to the system.
> Required Properties:
>
> - compatible: Should be one of:
> + - "mediatek,mt6765-camsys", "syscon"
> - "mediatek,mt6779-camsys", "syscon"
> - "mediatek,mt8183-camsys", "syscon"
> - #clock-cells: Must be 1
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,imgsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,imgsys.txt
> index 2b693e343c56..1e1f00718a7d 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,imgsys.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,imgsys.txt
> @@ -8,6 +8,7 @@ Required Properties:
> - compatible: Should be one of:
> - "mediatek,mt2701-imgsys", "syscon"
> - "mediatek,mt2712-imgsys", "syscon"
> + - "mediatek,mt6765-imgsys", "syscon"
> - "mediatek,mt6779-imgsys", "syscon"
> - "mediatek,mt6797-imgsys", "syscon"
> - "mediatek,mt7623-imgsys", "mediatek,mt2701-imgsys", "syscon"
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt
> index db2f4fd754e7..49a968be1a80 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,infracfg.txt
> @@ -9,6 +9,7 @@ Required Properties:
> - compatible: Should be one of:
> - "mediatek,mt2701-infracfg", "syscon"
> - "mediatek,mt2712-infracfg", "syscon"
> + - "mediatek,mt6765-infracfg", "syscon"
> - "mediatek,mt6779-infracfg_ao", "syscon"
> - "mediatek,mt6797-infracfg", "syscon"
> - "mediatek,mt7622-infracfg", "syscon"
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mipi0a.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mipi0a.txt
> new file mode 100644
> index 000000000000..8be5978f388d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mipi0a.txt
> @@ -0,0 +1,28 @@
> +Mediatek mipi0a (mipi_rx_ana_csi0a) controller
> +============================
> +
> +The Mediatek mipi0a controller provides various clocks
> +to the system.
> +
> +Required Properties:
> +
> +- compatible: Should be one of:
> + - "mediatek,mt6765-mipi0a", "syscon"
> +- #clock-cells: Must be 1
> +
> +The mipi0a controller uses the common clk binding from
> +Documentation/devicetree/bindings/clock/clock-bindings.txt
> +The available clocks are defined in dt-bindings/clock/mt*-clk.h.
> +
> +The mipi0a controller also uses the common power domain from
> +Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> +The available power doamins are defined in dt-bindings/power/mt*-power.h.
> +
> +Example:
> +
> +mipi0a: clock-controller@...10000 {
> + compatible = "mediatek,mt6765-mipi0a", "syscon";
> + reg = <0 0x11c10000 0 0x1000>;
> + power-domains = <&scpsys MT6765_POWER_DOMAIN_CAM>;
> + #clock-cells = <1>;
> +};
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> index 301eefbe1618..4a712509bec2 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> @@ -8,6 +8,7 @@ Required Properties:
> - compatible: Should be one of:
> - "mediatek,mt2701-mmsys", "syscon"
> - "mediatek,mt2712-mmsys", "syscon"
> + - "mediatek,mt6765-mmsys", "syscon"
> - "mediatek,mt6779-mmsys", "syscon"
> - "mediatek,mt6797-mmsys", "syscon"
> - "mediatek,mt7623-mmsys", "mediatek,mt2701-mmsys", "syscon"
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.txt
> index ecf027a9003a..dcbd414c7fd7 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.txt
> @@ -9,6 +9,7 @@ Required Properties:
> - compatible: Should be one of:
> - "mediatek,mt2701-pericfg", "syscon"
> - "mediatek,mt2712-pericfg", "syscon"
> + - "mediatek,mt6765-pericfg", "syscon"
> - "mediatek,mt7622-pericfg", "syscon"
> - "mediatek,mt7623-pericfg", "mediatek,mt2701-pericfg", "syscon"
> - "mediatek,mt7629-pericfg", "syscon"
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt
> index 0293d693ce0c..9b0394cbbdc9 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,topckgen.txt
> @@ -8,6 +8,7 @@ Required Properties:
> - compatible: Should be one of:
> - "mediatek,mt2701-topckgen"
> - "mediatek,mt2712-topckgen", "syscon"
> + - "mediatek,mt6765-topckgen", "syscon"
> - "mediatek,mt6779-topckgen", "syscon"
> - "mediatek,mt6797-topckgen"
> - "mediatek,mt7622-topckgen"
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,vcodecsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,vcodecsys.txt
> new file mode 100644
> index 000000000000..c877bcc1a5c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,vcodecsys.txt
> @@ -0,0 +1,27 @@
> +Mediatek vcodecsys controller
> +============================
> +
> +The Mediatek vcodecsys controller provides various clocks to the system.
> +
> +Required Properties:
> +
> +- compatible: Should be one of:
> + - "mediatek,mt6765-vcodecsys", "syscon"
> +- #clock-cells: Must be 1
> +
> +The vcodecsys controller uses the common clk binding from
> +Documentation/devicetree/bindings/clock/clock-bindings.txt
> +The available clocks are defined in dt-bindings/clock/mt*-clk.h.
> +
> +The vcodecsys controller also uses the common power domain from
> +Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> +The available power doamins are defined in dt-bindings/power/mt*-power.h.
> +
> +Example:
> +
> +venc_gcon: clock-controller@...00000 {
> + compatible = "mediatek,mt6765-vcodecsys", "syscon";
> + reg = <0 0x17000000 0 0x10000>;
> + power-domains = <&scpsys MT6765_POWER_DOMAIN_VCODEC>;
> + #clock-cells = <1>;
> +};
>
Powered by blists - more mailing lists