linux-kernel - Re: [PATCH v3 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ea1e6a5-4942-5dba-4e91-28275db00153@codeaurora.org>
Date:   Tue, 18 Feb 2020 23:42:41 +0530
From:   Taniya Das <tdas@...eaurora.org>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Gross <agross@...nel.org>, devicetree@...r.kernel.org,
        robh@...nel.org, robh+dt@...nel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: clock: Add YAML schemas for the QCOM
 MSS clock bindings

Thanks Stephen.
Will address the comments in the next patch series.

On 1/30/2020 11:36 PM, Stephen Boyd wrote:
> Quoting Taniya Das (2020-01-29 20:18:41)
>> The Modem Subsystem clock provider have a bunch of generic properties
>> that are needed in a device tree. Add a YAML schemas for those.
>>
>> Signed-off-by: Taniya Das <tdas@...eaurora.org>
>> ---
>>   .../devicetree/bindings/clock/qcom,mss.yaml        | 58 ++++++++++++++++++++++
> 
> Please rename to qcom,sc7180-mss.yaml
> 
>>   1 file changed, 58 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/qcom,mss.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,mss.yaml b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
>> new file mode 100644
>> index 0000000..ebb04e1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
>> @@ -0,0 +1,58 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/bindings/clock/qcom,mss.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Modem Clock Controller Binding
>> +
>> +maintainers:
>> +  - Taniya Das <tdas@...eaurora.org>
>> +
>> +description: |
>> +  Qualcomm modem clock control module which supports the clocks.
> 
> Can you point to the header file from here?
> include/dt-bindings/clock/qcom,sc7180-mss.h I guess.
> 

will add the same.

>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +       - qcom,sc7180-mss
>> +
>> +  clocks:
>> +    minItems: 1
>> +    maxItems: 3
> 
> Why is it optional? Don't these all go there?
> 

Yes, moved them to required.

>> +    items:
>> +      - description: gcc_mss_mfab_axi clock from GCC
>> +      - description: gcc_mss_nav_axi clock from GCC
>> +      - description: gcc_mss_cfg_ahb clock from GCC
>> +
>> +  clock-names:
>> +    items:
>> +      - const: gcc_mss_mfab_axis_clk
>> +      - const: gcc_mss_nav_axi_clk
>> +      - const: cfg_clk
> 
> Do these really need _clk at the end? Seems redundant.
> 
Removed _clk.

>> +
>> +  '#clock-cells':
>> +    const: 1
>> +

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--