linux-kernel - Re: [PATCH v3 3/3] clk: qcom: Add modem clock controller driver for SC7180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <255a6ddf-bd34-3249-ad86-62cb486a7e41@codeaurora.org>
Date:   Tue, 18 Feb 2020 23:52:39 +0530
From:   Taniya Das <tdas@...eaurora.org>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Gross <agross@...nel.org>, devicetree@...r.kernel.org,
        robh@...nel.org, robh+dt@...nel.org
Subject: Re: [PATCH v3 3/3] clk: qcom: Add modem clock controller driver for
 SC7180



On 1/30/2020 11:38 PM, Stephen Boyd wrote:
> Quoting Taniya Das (2020-01-29 20:18:43)
>> Add support for the modem clock controller found on SC7180
>> based devices. This would allow modem drivers to probe and
>> control their clocks.
>>
>> Signed-off-by: Taniya Das <tdas@...eaurora.org>
>> ---
>>   drivers/clk/qcom/Kconfig      |   9 +++
>>   drivers/clk/qcom/Makefile     |   1 +
>>   drivers/clk/qcom/gcc-sc7180.c |  70 +++++++++++++++++++++
>>   drivers/clk/qcom/mss-sc7180.c | 143 ++++++++++++++++++++++++++++++++++++++++++
> 
> Please split this patch into two, one for gcc and one for mss.
> 

Taken care in the next patch series.

>>   4 files changed, 223 insertions(+)
>>   create mode 100644 drivers/clk/qcom/mss-sc7180.c
>>
>> diff --git a/drivers/clk/qcom/mss-sc7180.c b/drivers/clk/qcom/mss-sc7180.c
>> new file mode 100644
>> index 0000000..d82600e
>> --- /dev/null
>> +++ b/drivers/clk/qcom/mss-sc7180.c
>> @@ -0,0 +1,143 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2019, The Linux Foundation. All rights reserved.
>> + */
>> +
>> +#include <linux/clk-provider.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/module.h>
>> +#include <linux/of_address.h>
>> +#include <linux/pm_clock.h>
>> +#include <linux/pm_runtime.h>
>> +#include <linux/regmap.h>
>> +
>> +#include <dt-bindings/clock/qcom,mss-sc7180.h>
>> +
>> +#include "clk-regmap.h"
>> +#include "clk-branch.h"
>> +#include "common.h"
>> +
> [...]
>> +
>> +static struct regmap_config mss_regmap_config = {
> 
> Can this be const?
>

Yes, next series is updated with the above.

>> +       .reg_bits       = 32,
>> +       .reg_stride     = 4,
>> +       .val_bits       = 32,
>> +       .fast_io        = true,
>> +};
>> +

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--