linux-kernel - Re: [PATCH] dma-buf: free dmabuf->name in dma_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Feb 2020 10:41:16 -0800
From:   Chenbo Feng <fengc@...gle.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     DRI mailing list <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-media@...r.kernel.org,
        syzbot+b2098bc44728a4efb3e9@...kaller.appspotmail.com,
        Greg Hackmann <ghackmann@...gle.com>,
        Sumit Semwal <sumit.semwal@...aro.org>
Subject: Re: [PATCH] dma-buf: free dmabuf->name in dma_buf_release()

Acked-by: Chenbo Feng <fengc@...gle.com>


On Thu, Dec 26, 2019 at 10:32 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set
> it never gets freed.
>
> Free it in dma_buf_release().
>
> Fixes: bb2bb9030425 ("dma-buf: add DMA_BUF_SET_NAME ioctls")
> Reported-by: syzbot+b2098bc44728a4efb3e9@...kaller.appspotmail.com
> Cc: Greg Hackmann <ghackmann@...gle.com>
> Cc: Chenbo Feng <fengc@...gle.com>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  drivers/dma-buf/dma-buf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index ce41cd9b758a..2427398ff22a 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)
>                 dma_resv_fini(dmabuf->resv);
>
>         module_put(dmabuf->owner);
> +       kfree(dmabuf->name);
>         kfree(dmabuf);
>         return 0;
>  }
> --
> 2.21.0
>