lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Feb 2020 18:50:00 +0100 From: Krzysztof Kozlowski <krzk@...nel.org> To: Richard Henderson <rth@...ddle.net>, Ivan Kokshaysky <ink@...assic.park.msu.ru>, Matt Turner <mattst88@...il.com>, Alexey Brodkin <abrodkin@...opsys.com>, Vineet Gupta <vgupta@...opsys.com>, "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, Helge Deller <deller@....de>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Michael Ellerman <mpe@...erman.id.au>, Yoshinori Sato <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, Dave Airlie <airlied@...hat.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Ben Skeggs <bskeggs@...hat.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Jiri Slaby <jirislaby@...il.com>, Nick Kossifidis <mickflemm@...il.com>, Luis Chamberlain <mcgrof@...nel.org>, Kalle Valo <kvalo@...eaurora.org>, "David S. Miller" <davem@...emloft.net>, Dave Jiang <dave.jiang@...el.com>, Jon Mason <jdmason@...zu.us>, Allen Hubbe <allenbh@...il.com>, "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Arnd Bergmann <arnd@...db.de>, Geert Uytterhoeven <geert+renesas@...der.be>, Andrew Morton <akpm@...ux-foundation.org>, Thomas Gleixner <tglx@...utronix.de>, linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org, linux-snps-arc@...ts.infradead.org, linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org, dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org, linux-media@...r.kernel.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-ntb@...glegroups.com, virtualization@...ts.linux-foundation.org, linux-arch@...r.kernel.org Cc: Krzysztof Kozlowski <krzk@...nel.org> Subject: [RESEND PATCH v2 2/9] rtl818x: Constify ioreadX() iomem argument (as in generic implementation) The ioreadX() helpers have inconsistent interface. On some architectures void *__iomem address argument is a pointer to const, on some not. Implementations of ioreadX() do not modify the memory under the address so they can be converted to a "const" version for const-safety and consistency among architectures. Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be> Acked-by: Kalle Valo <kvalo@...eaurora.org> --- Changes since v1: 1. Add Geert's review. 2. Add Kalle's ack. Fix subject prefix. --- drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h b/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h index 7948a2da195a..2ff00800d45b 100644 --- a/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h +++ b/drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h @@ -150,17 +150,17 @@ void rtl8180_write_phy(struct ieee80211_hw *dev, u8 addr, u32 data); void rtl8180_set_anaparam(struct rtl8180_priv *priv, u32 anaparam); void rtl8180_set_anaparam2(struct rtl8180_priv *priv, u32 anaparam2); -static inline u8 rtl818x_ioread8(struct rtl8180_priv *priv, u8 __iomem *addr) +static inline u8 rtl818x_ioread8(struct rtl8180_priv *priv, const u8 __iomem *addr) { return ioread8(addr); } -static inline u16 rtl818x_ioread16(struct rtl8180_priv *priv, __le16 __iomem *addr) +static inline u16 rtl818x_ioread16(struct rtl8180_priv *priv, const __le16 __iomem *addr) { return ioread16(addr); } -static inline u32 rtl818x_ioread32(struct rtl8180_priv *priv, __le32 __iomem *addr) +static inline u32 rtl818x_ioread32(struct rtl8180_priv *priv, const __le32 __iomem *addr) { return ioread32(addr); } -- 2.17.1
Powered by blists - more mailing lists