linux-kernel - Re: [PATCH] staging: comedi: change CamelCase to CAPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Feb 2020 19:46:16 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Kaaira Gupta <kgupta@...iitr.ac.in>
Cc:     Ian Abbott <abbotti@....co.uk>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: change CamelCase to CAPS

On Wed, Feb 19, 2020 at 11:16:46PM +0530, Kaaira Gupta wrote:
> fix checkpatch.pl check of 'Avoid CamelCase' by changing NI_CtrSource to
> NI_CTRSOURCE in all the files. Change it to CAPS because it is a MICRO

What is a "MICRO"?

> Signed-off-by: Kaaira Gupta <kgupta@...iitr.ac.in>

Are you sure this is ok?  I think this comes directly from a spec sheet
so changing it might not be good.

as proof:

> @@ -104,7 +104,7 @@ struct ni_device_routes ni_pci_6070e_device_routes = {
>  		{
>  			.dest = TRIGGER_LINE(0),
>  			.src = (int[]){
> -				NI_CtrSource(0),
> +				NI_CTRSOURCE(0),
>  				NI_CtrGate(0),
>  				NI_CtrInternalOutput(0),
>  				NI_CtrOut(0),

Looks like all of these are CamelCase, why are you changing only one?
They all should be the same, and odds are, how they are today is fine,
right?

Look at the git history of these files to be sure.

thanks,

greg k-h