[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <538b8ba7-e6d3-e8f2-0cc6-ce3485bc7848@gmail.com>
Date: Wed, 19 Feb 2020 11:13:30 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
linux-kernel@...r.kernel.org,
Florian Fainelli <f.fainelli@...il.com>,
Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
bcm-kernel-feedback-list@...adcom.com
Cc: linux-usb@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, gregkh@...uxfoundation.org,
tim.gover@...pberrypi.org, linux-pci@...r.kernel.org,
wahrenst@....net
Subject: Re: [PATCH v2 2/4] firmware: raspberrypi: Introduce vl805 init
routine
On 2/19/20 4:39 AM, Nicolas Saenz Julienne wrote:
> On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
> loaded directly from an EEPROM or, if not present, by the SoC's
> VideCore. The function informs VideCore that VL805 was just reset, or
> requests for a probe defer.
>
> Based on Tim Gover's downstream implementation.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> ---
[snip]
> diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
> index cc9cdbc66403..a37c3a461d2a 100644
> --- a/include/soc/bcm2835/raspberrypi-firmware.h
> +++ b/include/soc/bcm2835/raspberrypi-firmware.h
> @@ -8,6 +8,7 @@
>
> #include <linux/types.h>
> #include <linux/of_device.h>
> +#include <linux/pci.h>
I would move this inclusion where we need it, which is in
drivers/firmware/raspberrypi.c and only provide a forward declaration
here (avoids needless rebuilds).
With that:
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists