linux-kernel - Re: [PATCH v5 4/8] drivers: thermal: tsens: Release device in success path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <158215294977.184098.9773724834739432956@swboyd.mtv.corp.google.com>
Date:   Wed, 19 Feb 2020 14:55:49 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>,
        Andy Gross <agross@...nel.org>, bjorn.andersson@...aro.org,
        daniel.lezcano@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, sivaa@...eaurora.org
Cc:     Amit Kucheria <amit.kucheria@...durent.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v5 4/8] drivers: thermal: tsens: Release device in success path

Quoting Amit Kucheria (2020-02-18 10:12:08)
> We don't currently call put_device in case of successfully initialising
> the device.

Sure, but why is that a problem? Presumably the device is kept pinned
forever?

> 
> Allow control to fall through so we can use same code for success and
> error paths to put_device.
> 
> As a part of this fixup, change devm_ioremap_resource to act on the same
> device pointer as that used to allocate regmap memory. That ensures that
> we are free to release op->dev after examining its resources.
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>