linux-kernel - Re: [PATCH v8 bpf-next 2/2] selftests/bpf: add bpf_read_branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLbBm6SULFf3sGNWznc2Q+pALLJpLsMO9XuyY1oXQoO6w@mail.gmail.com>
Date:   Wed, 19 Feb 2020 15:03:36 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Xu <dxu@...uu.xyz>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        LKML <linux-kernel@...r.kernel.org>,
        Kernel Team <kernel-team@...com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH v8 bpf-next 2/2] selftests/bpf: add bpf_read_branch_records()
 selftest

On Wed, Feb 19, 2020 at 2:47 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Mon, Feb 17, 2020 at 7:04 PM Daniel Xu <dxu@...uu.xyz> wrote:
> >
> > Add a selftest to test:
> >
> > * default bpf_read_branch_records() behavior
> > * BPF_F_GET_BRANCH_RECORDS_SIZE flag behavior
> > * error path on non branch record perf events
> > * using helper to write to stack
> > * using helper to write to global
> >
> > On host with hardware counter support:
> >
> >     # ./test_progs -t perf_branches
> >     #27/1 perf_branches_hw:OK
> >     #27/2 perf_branches_no_hw:OK
> >     #27 perf_branches:OK
> >     Summary: 1/2 PASSED, 0 SKIPPED, 0 FAILED
> >
> > On host without hardware counter support (VM):
> >
> >     # ./test_progs -t perf_branches
> >     #27/1 perf_branches_hw:OK
> >     #27/2 perf_branches_no_hw:OK
> >     #27 perf_branches:OK
> >     Summary: 1/2 PASSED, 1 SKIPPED, 0 FAILED
>
> That's not what I see:
> ./test_progs -t perf_branches
> test_perf_branches_hw:FAIL:perf_event_open err -1
> #27/1 perf_branches_hw:FAIL
> #27/2 perf_branches_no_hw:OK
> #27 perf_branches:FAIL
> Summary: 0/1 PASSED, 0 SKIPPED, 2 FAILED
>
> I remember previous version used to work, but something changed.

Looks like the error code has changed.
I've added
if (errno == ENOENT || errno == EOPNOTSUPP)
and applied.
Please test your patches more carefully next time.