linux-kernel - Re: [RFC PATCH 0/2] trace: Move trace data to new section _ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200218215328.16744447@gandalf.local.home>
Date:   Tue, 18 Feb 2020 21:53:28 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 0/2] trace: Move trace data to new section
 _ftrace_data

On Tue, 18 Feb 2020 18:03:16 -0800
Joe Perches <joe@...ches.com> wrote:

> Move the trace data to a separate section to make it easier to
> examine the amount of actual data in an object file.

Not that I'm against this patch set, but can you elaborate more on
"make it easier to examine the amount of actual data in an object file".

Also, don't use "_ftrace" as the section name. "ftrace" should be
reserved for the function hook part of tracing, which trace events do
not apply to. "_trace_event_data" would be more appropriate.

-- Steve


> 
> Joe Perches (2):
>   trace: Move data to new section _ftrace_data
>   trace_events/trace_export: Use __section
> 
>  include/trace/trace_events.h | 36 +++++++++++++++++++++---------------
>  kernel/trace/trace_export.c  | 13 ++++++++-----
>  2 files changed, 29 insertions(+), 20 deletions(-)
>