linux-kernel - Re: [PATCH v3 1/2] dt-bindings: clock: Add binding documentation for TI syscon gate clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200219025811.GA20054@bogus>
Date:   Tue, 18 Feb 2020 20:58:11 -0600
From:   Rob Herring <robh@...nel.org>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tero Kristo <t-kristo@...com>
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: Add binding documentation for
 TI syscon gate clock

On Sat, Feb 15, 2020 at 07:47:23PM +0530, Vignesh Raghavendra wrote:
> Add dt bindings for TI syscon gate clock driver that is used to control
> EHRPWM's TimeBase clock (TBCLK) on TI's AM654 SoC.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> ---
>  .../bindings/clock/ti,am654-ehrpwm-tbclk.yaml | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> new file mode 100644
> index 000000000000..3bf954ecb803
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI syscon gate clock driver

Bindings are for h/w blocks, not drivers.

> +
> +maintainers:
> +  - Vignesh Raghavendra <vigneshr@...com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: ti,am654-ehrpwm-tbclk
> +      - const: syscon

Why is this a syscon? Are there other functions or it's just the easy 
way to get a regmap.

> +
> +  "#clock-cells":
> +    const: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - "#clock-cells"
> +  - reg
> +
> +examples:
> +  - |
> +    ehrpwm_tbclk: syscon@...0 {
> +        compatible = "ti,am654-ehrpwm-tbclk", "syscon";
> +        reg = <0x4140 0x18>;
> +        #clock-cells = <1>;
> +    };
> -- 
> 2.25.0
>