linux-kernel - Re: [PATCH 00/20] usb: remove useless cast for driver.name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200219075247.GE2090@localhost>
Date:   Wed, 19 Feb 2020 08:52:47 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     alexandre.belloni@...tlin.com, b-liu@...com, balbi@...nel.org,
        gregkh@...uxfoundation.org, ludovic.desroches@...rochip.com,
        mathias.nyman@...el.com, nicolas.ferre@...rochip.com,
        slemieux.tyco@...il.com, stern@...land.harvard.edu, vz@...ia.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 00/20] usb: remove useless cast for driver.name

On Tue, Feb 18, 2020 at 07:32:43PM +0000, Corentin Labbe wrote:
> This serie remove a useless (char*) cast for some xxx_driver.name.
> pci_driver, device_driver, usb_composite_driver structures have a "name"
> member which is const char * and all the driver patched assigned to it a
> const char[] name, so the cast was bad and unnecessary.
> 
> Corentin Labbe (20):
>   usb: gadget: legacy: gmidi: remove useless cast for driver.name
>   usb: gadget: legacy: inode: remove useless cast for driver.name
>   usb: gadget: udc: amd5536udc_pci: remove useless cast for driver.name
>   usb: gadget: at91_udc: remove useless cast for driver.name
>   usb: gadget: dummy_hcd: remove useless cast for driver.name
>   usb: gadget: fotg210-udc: remove useless cast for driver.name
>   usb: gadget: fusb300_udc: remove useless cast for driver.name
>   usb: gadget: goku_udc: remove useless cast for driver.name
>   usb: gadget: lpc32xx_udc: remove useless cast for driver.name
>   usb: gadget: m66592-udc: remove useless cast for driver.name
>   usb: gadget: net2280: remove useless cast for driver.name
>   usb: gadget: omap_udc: remove useless cast for driver.name
>   usb: gadget: r8a66597-udc: remove useless cast for driver.name
>   usb: gadget: renesas_usb3: remove useless cast for driver.name
>   usb: host: ehci-pci: remove useless cast for driver.name
>   usb: host: ohci-pci: remove useless cast for driver.name
>   usb: host: sl811-hcd: remove useless cast for driver.name
>   usb: host: uhci-pci: remove useless cast for driver.name
>   usb: host: xhci-pci: remove useless cast for driver.name
>   usb: musb: core: remove useless cast for driver.name

Please do trivial conversions like this one in one patch per subsystem
(e.g. all of USB) instead of 20 one-line patches.

You may also want to refer to commit 8d790d740858 ("[PATCH] make
driver's name be const char *") for the historical background for this
in the commit message.

>  drivers/usb/gadget/legacy/gmidi.c       | 2 +-
>  drivers/usb/gadget/legacy/inode.c       | 2 +-
>  drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
>  drivers/usb/gadget/udc/at91_udc.c       | 2 +-
>  drivers/usb/gadget/udc/dummy_hcd.c      | 4 ++--
>  drivers/usb/gadget/udc/fotg210-udc.c    | 2 +-
>  drivers/usb/gadget/udc/fusb300_udc.c    | 2 +-
>  drivers/usb/gadget/udc/goku_udc.c       | 2 +-
>  drivers/usb/gadget/udc/lpc32xx_udc.c    | 2 +-
>  drivers/usb/gadget/udc/m66592-udc.c     | 2 +-
>  drivers/usb/gadget/udc/net2280.c        | 2 +-
>  drivers/usb/gadget/udc/omap_udc.c       | 2 +-
>  drivers/usb/gadget/udc/r8a66597-udc.c   | 2 +-
>  drivers/usb/gadget/udc/renesas_usb3.c   | 2 +-
>  drivers/usb/host/ehci-pci.c             | 2 +-
>  drivers/usb/host/ohci-pci.c             | 2 +-
>  drivers/usb/host/sl811-hcd.c            | 2 +-
>  drivers/usb/host/uhci-pci.c             | 2 +-
>  drivers/usb/host/xhci-pci.c             | 2 +-
>  drivers/usb/musb/musb_core.c            | 2 +-
>  20 files changed, 21 insertions(+), 21 deletions(-)

Thanks,
Johan