linux-kernel - Re: [RFC PATCH 2/3] power: (regmap:) Add linear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0237802eed73451f85835c6bd1164411b901778.camel@fi.rohmeurope.com>
Date:   Wed, 19 Feb 2020 08:14:11 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "broonie@...nel.org" <broonie@...nel.org>
CC:     "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "Mutanen, Mikko" <Mikko.Mutanen@...rohmeurope.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "Laine, Markus" <Markus.Laine@...rohmeurope.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [RFC PATCH 2/3] power: (regmap:) Add linear_range helper

Hello Mark,

On Tue, 2020-02-18 at 13:49 +0000, Mark Brown wrote:
> On Tue, Feb 18, 2020 at 07:23:38AM +0000, Vaittinen, Matti wrote:
> 
> > By the way - do you have some nice test cases for regulators hidden
> > somewhere? If so, do you think you could share them? I sure have
> > some
> > for BD718x7 but they are somewhat clumsy and require special HW.
> > (I've
> > never liked unit-tests but I must admit there are some specific
> > cases
> > where they would be pretty usable).
> 
> You can't really run tests on actual regulator drivers outside of
> test
> rigs as they're kind of important to the system they're running in.

Right. I was thinking of some tests which would only be testing the
vsel logic by feeding test ranges to functions and verifying the
resulting selectors/voltages were correct. Unit test style thing where
part of the code is stubbed out and rest is compiled into a test
executable. I know some people do such (and I usually don't see the
effort/benefit ratio to be too great there - although there are cases
where such tests can be beneficial). So I decided to ask if you are one
of those who do such testing and happened to have such for regulator
functions. But this is clear now.

I'll try running some tests on BD71847 break-out board at the end of
RFC phase - but I do appreciate all the testing on other systems as
well! Touching the regulator core is a bit scary as it can result ...
problems :/

Best Regards
	Matti Vaittinen