lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Feb 2020 09:41:04 +0100 From: Jiri Slaby <jslaby@...e.cz> To: gregkh@...uxfoundation.org Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org, Jiri Slaby <jslaby@...e.cz> Subject: [PATCH 10/24] n_hdlc: remove unused backup_tty It's only set to NULL and never properly used. Signed-off-by: Jiri Slaby <jslaby@...e.cz> --- drivers/tty/n_hdlc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/tty/n_hdlc.c b/drivers/tty/n_hdlc.c index d0e538ba51ea..ae6b9a45ae81 100644 --- a/drivers/tty/n_hdlc.c +++ b/drivers/tty/n_hdlc.c @@ -125,7 +125,6 @@ struct n_hdlc_buf_list { * struct n_hdlc - per device instance data structure * @magic - magic value for structure * @tty - ptr to TTY structure - * @backup_tty - TTY to use if tty gets closed * @tbusy - reentrancy flag for tx wakeup code * @woke_up - FIXME: describe this field * @tx_buf_list - list of pending transmit frame buffers @@ -136,7 +135,6 @@ struct n_hdlc_buf_list { struct n_hdlc { int magic; struct tty_struct *tty; - struct tty_struct *backup_tty; int tbusy; int woke_up; struct n_hdlc_buf_list tx_buf_list; @@ -267,15 +265,9 @@ static void n_hdlc_tty_close(struct tty_struct *tty) clear_bit(TTY_NO_WRITE_SPLIT,&tty->flags); #endif tty->disc_data = NULL; - if (tty == n_hdlc->backup_tty) - n_hdlc->backup_tty = NULL; if (tty != n_hdlc->tty) return; - if (n_hdlc->backup_tty) { - n_hdlc->tty = n_hdlc->backup_tty; - } else { - n_hdlc_release (n_hdlc); - } + n_hdlc_release (n_hdlc); } /* end of n_hdlc_tty_close() */ /** -- 2.25.0
Powered by blists - more mailing lists