linux-kernel - Re: [PATCH v4 1/6] PCI: rcar: Preparation for adding endpoint support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+V-a8sBPT-RLvzRFFFwbNghD9X26P5qPntoUvgNHQ6_eUzQBg@mail.gmail.com>
Date:   Wed, 19 Feb 2020 09:06:45 +0000
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Andrew Murray <andrew.murray@....com>,
        linux-pci <linux-pci@...r.kernel.org>,
        LAK <linux-arm-kernel@...ts.infradead.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v4 1/6] PCI: rcar: Preparation for adding endpoint support

Hi Bjorn,

Thank you for the review.

On Wed, Feb 12, 2020 at 2:01 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> To make the changelog from "git log --oneline" read nicely, the
> subject should begin with a verb, e.g.,
>
>   PCI: rcar: Move shareable code to a common file
>
> On Sat, Feb 08, 2020 at 06:36:36PM +0000, Lad Prabhakar wrote:
> > Prepare for adding endpoint support to rcar controller, there are no
> > functional changes with this patch, a common file is created so that
> > it can be shared with endpoint driver.
>
> This commit log doesn't tell us what this patch does.  "Prepare"
> conveys no real information.  It's a giant patch and it's difficult
> to verify that there's no functional change.
>
> I *think* what you did was move most of the #defines from pcie-rcar.c
> to pcie-rcar.h and most of the code from pcie-rcar.c to
> pcie-rcar-host.c.  And in both case, these were strict *moves* without
> any changes.  If that's the case, please say that explicitly in the
> commit log.
>
> That's good; thanks for making this a separate patch so it's not
> mingled with real changes.
>
Agreed I shall split this patch further more, first patch just
renaming the file from
pcie-rcar.c to pcie-rcar-host.c along with Makefile/Kconfig/defconfig
changes and
the second patch pulling out common code that shall be share between
two drivers.
This shall make it more easier to review.

> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> >  arch/arm64/configs/defconfig            |    2 +-
> >  drivers/pci/controller/Kconfig          |    4 +-
> >  drivers/pci/controller/Makefile         |    2 +-
> >  drivers/pci/controller/pcie-rcar-host.c | 1044 ++++++++++++++++++++++++++
> >  drivers/pci/controller/pcie-rcar.c      | 1229 ++-----------------------------
> >  drivers/pci/controller/pcie-rcar.h      |  126 ++++
> >  6 files changed, 1227 insertions(+), 1180 deletions(-)
> >  create mode 100644 drivers/pci/controller/pcie-rcar-host.c
> >  create mode 100644 drivers/pci/controller/pcie-rcar.h
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index b2f6673..8a1f51d 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -182,7 +182,7 @@ CONFIG_HOTPLUG_PCI=y
> >  CONFIG_HOTPLUG_PCI_ACPI=y
> >  CONFIG_PCI_AARDVARK=y
> >  CONFIG_PCI_TEGRA=y
> > -CONFIG_PCIE_RCAR=y
> > +CONFIG_PCIE_RCAR_HOST=y
> >  CONFIG_PCI_HOST_GENERIC=y
> >  CONFIG_PCI_XGENE=y
> >  CONFIG_PCIE_ALTERA=y
> > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> > index f84e5ff..94bb5e9 100644
> > --- a/drivers/pci/controller/Kconfig
> > +++ b/drivers/pci/controller/Kconfig
> > @@ -54,12 +54,12 @@ config PCI_RCAR_GEN2
> >         There are 3 internal PCI controllers available with a single
> >         built-in EHCI/OHCI host controller present on each one.
> >
> > -config PCIE_RCAR
> > +config PCIE_RCAR_HOST
>
> The config symbol change should be mentioned in the commit log.  In
> general we try to avoid changing config symbols because it's likely to
> confuse people who keep their .config and update their kernel.  But I
> guess your audience is probably pretty small.
>
I shall mention it in my commit message.

> >       bool "Renesas R-Car PCIe controller"
>
> The description needs to be updated, too.  This is what people will
> see in menuconfig.
>
I shall update it accordingly.

> >       depends on ARCH_RENESAS || COMPILE_TEST
> >       depends on PCI_MSI_IRQ_DOMAIN
> >       help
> > -       Say Y here if you want PCIe controller support on R-Car SoCs.
> > +       Say Y here if you want PCIe controller support on R-Car SoCs in host mode.
>
> Wrap this so it fits in 80 columns like the rest of the file.
>
Will fix that.

Cheers,
--Prabhakar Lad

> Bjorn