linux-kernel - Re: [PATCH] xhci: Do not open code __print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Feb 2020 11:20:08 +0200
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org,
        Tzvetomir Stoyanov <tstoyanov@...are.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
Subject: Re: [PATCH] xhci: Do not open code __print_symbolic() in xhci trace
 events

On 14.2.2020 18.56, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@...dmis.org>
> 
> libtraceevent (used by perf and trace-cmd) failed to parse the
> xhci_urb_dequeue trace event. This is because the user space trace
> event format parsing is not a full C compiler. It can handle some basic
> logic, but is not meant to be able to handle everything C can do.
> 
> In cases where a trace event field needs to be converted from a number
> to a string, there's the __print_symbolic() macro that should be used:
> 
>  See samples/trace_events/trace-events-sample.h
> 
> Some xhci trace events open coded the __print_symbolic() causing the
> user spaces tools to fail to parse it. This has to be replaced with
> __print_symbolic() instead.
> 
> CC: stable@...r.kernel.org
> Reported-by: Tzvetomir Stoyanov <tstoyanov@...are.com>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=206531
> Fixes: 5abdc2e6e12ff ("usb: host: xhci: add urb_enqueue/dequeue/giveback tracers")
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> ---

Thanks
Added to queue

-Mathias